Skip to content

Create proper source tarballs in CI/on releases #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hasufell opened this issue Sep 19, 2021 · 7 comments · Fixed by #2248
Closed

Create proper source tarballs in CI/on releases #2216

hasufell opened this issue Sep 19, 2021 · 7 comments · Fixed by #2248
Labels

Comments

@hasufell
Copy link
Member

hasufell commented Sep 19, 2021

Implementing https://gitlab.haskell.org/haskell/ghcup-hs/-/merge_requests/180 I need proper source tarballs.

The default ones are:

  1. autogenerated and would depend on github not messing with the tarball layout (they did so at least twice) for the hash to be stable
  2. depend on the tag (yeah, if you force push, the hash changes too)
  3. have bad tarball names like 1.4.0.tar.gz, causing trouble for ghcup

Something like:

git archive --prefix=haskell-language-server-${version}/ --format=tar.gz -o haskell-language-server-${version}.tar.gz HEAD

in CI should do the trick.

@jneira
Copy link
Member

jneira commented Sep 24, 2021

@hasufell the mr is merged and released, how could improve it creating source tarballs here? are you using them from gitlab in the actual version?

@hasufell
Copy link
Member Author

ghcup is using the source tarballs

@jneira
Copy link
Member

jneira commented Sep 24, 2021

ghcup is using the source tarballs

the default ones from github? so improving them would allow clean ghcup code

@hasufell
Copy link
Member Author

hasufell commented Sep 24, 2021

the default ones from github? so improving them would allow clean ghcup code

I don't understand what you mean. ghcup needs source tarballs to compile HLS from source. The automatically generated ones aren't good enough as I described in the first comment.

@jneira
Copy link
Member

jneira commented Sep 24, 2021

ghcup is using the source tarballs

hmm so if default ones are not valid and we are not generating in github the good ones yet, Where are the tarballs it is using now from?

@hasufell
Copy link
Member Author

Where are the tarballs it is using now from?

Created on my own.

@jneira
Copy link
Member

jneira commented Sep 24, 2021

thanks, will add a job in the build workflow to generate and add them to sha256 sums

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants