-
-
Notifications
You must be signed in to change notification settings - Fork 390
Create proper source tarballs in CI/on releases #2216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@hasufell the mr is merged and released, how could improve it creating source tarballs here? are you using them from gitlab in the actual version? |
ghcup is using the source tarballs |
the default ones from github? so improving them would allow clean ghcup code |
I don't understand what you mean. ghcup needs source tarballs to compile HLS from source. The automatically generated ones aren't good enough as I described in the first comment. |
hmm so if default ones are not valid and we are not generating in github the good ones yet, Where are the tarballs it is using now from? |
Created on my own. |
thanks, will add a job in the build workflow to generate and add them to sha256 sums |
Implementing https://gitlab.haskell.org/haskell/ghcup-hs/-/merge_requests/180 I need proper source tarballs.
The default ones are:
1.4.0.tar.gz
, causing trouble for ghcupSomething like:
in CI should do the trick.
The text was updated successfully, but these errors were encountered: