feedbacks

Author: pepeiborra

bench/README.md

@@ -11,7 +11,7 @@ By default it compares HEAD with "origin/master"
 
 The benchmark suites runs a set of experiments (hover, completion, edit, etc.)
 over all the defined examples (currently Cabal and lsp-types). Examples are defined
-in `bench/config.yaml` whereas experiments are coded in `ghcide/bench/lib/Experiments.hs`.
+in `bench/config.yaml` whereas experiments are coded in `ghcide-bench/src/Experiments.hs`.
 
 # Phony targets
 

bench/config.yaml

@@ -80,7 +80,21 @@ versions:
 # - HEAD~1
 - HEAD
 
+# A list of plugin configurations to analyze
 configurations:
+# A configuration contains one or more plugins:
+# - ConfigurationName:
+#   - plugin1
+#   - plugin2
+#
+# There is short-hand notation for defining singleton configurations.
+# Simply give the plugin name top level:
+# - plugin1
+#
+# Some plugins are implicitly included since they are required by the benchmark driver:
+# The implicitly included plugins are:
+# - ghcide-core
+# - ghcide-hover-and-symbols
 - None: []
 - Core:
   - callHierarchy

exe/Main.hs

@@ -3,7 +3,6 @@
 {-# LANGUAGE CPP               #-}
 {-# LANGUAGE NamedFieldPuns    #-}
 {-# LANGUAGE OverloadedStrings #-}
-{-# LANGUAGE PackageImports    #-}
 module Main(main) where
 
 import           Control.Arrow                ((&&&))

ghcide/.gitignore

@@ -7,11 +7,6 @@ cabal.project.local
 /.tasty-rerun-log
 .vscode
 /.hlint-*
-bench/example/*
-# don't ignore the example file, we need it!
-!bench/example/HLS
-bench-results/
-bench-temp/
 .shake/
 ghcide
 ghcide-bench

haskell-language-server.cabal

@@ -415,6 +415,8 @@ executable haskell-language-server
     -- Enable collection of heap statistics
     "-with-rtsopts=-I0 -A128M -T"
     -Wno-unticked-promoted-constructors
+  if flag(pedantic)
+    ghc-options: -Werror
   if !os(windows) && flag(dynamic)
   -- We want to link against the dyn rts just like official GHC binaries do;
   --   the linked rts determines how external libs are loaded dynamically by TH.