Skip to content

Commit 161c8ea

Browse files
committed
Fix errors
1 parent dd35a83 commit 161c8ea

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

flake.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343

4444
# not sure if this is the correct way to get lsp* packages in
4545
lsp = {
46-
url = "https://hackage.haskell.org/package/lsp-2.0.0.0/lsp-2.1.0.0.tar.gz";
46+
url = "https://hackage.haskell.org/package/lsp-2.1.0.0/lsp-2.1.0.0.tar.gz";
4747
flake = false;
4848
};
4949
lsp-types = {

ghcide/test/exe/Main.hs

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1563,18 +1563,13 @@ completionTest :: HasCallStack => String -> [T.Text] -> Position -> [(T.Text, Co
15631563
completionTest name src pos expected = testSessionWait name $ do
15641564
docId <- createDoc "A.hs" "haskell" (T.unlines src)
15651565
_ <- waitForDiagnostics
1566-
compls <- getCompletions docId pos
1566+
compls <- getAndResolveCompletions docId pos
15671567
let compls' = [ (_label, _kind, _insertText, _additionalTextEdits) | CompletionItem{..} <- compls]
15681568
let emptyToMaybe x = if T.null x then Nothing else Just x
15691569
liftIO $ sortOn (Lens.view Lens._1) (take (length expected) compls') @?=
15701570
sortOn (Lens.view Lens._1)
15711571
[ (l, Just k, emptyToMaybe t, at) | (l,k,t,_,_,at) <- expected]
1572-
forM_ (zip compls expected) $ \(item, (_,_,_,expectedSig, expectedDocs, _)) -> do
1573-
CompletionItem{..} <-
1574-
if (expectedSig || expectedDocs) && isJust (item ^. L.data_)
1575-
then do
1576-
resolveCompletionItem item
1577-
else pure item
1572+
forM_ (zip compls expected) $ \(CompletionItem{..}, (_,_,_,expectedSig, expectedDocs, _)) -> do
15781573
when expectedSig $
15791574
liftIO $ assertBool ("Missing type signature: " <> T.unpack _label) (isJust _detail)
15801575
when expectedDocs $

0 commit comments

Comments
 (0)