Support GHC 9.4

[andreasabel]

Blocked by:

• Support GHC 9.4 acid-state/safecopy#88
• Release for GHC 9.4.1 haddock#1507

[eddiejessup]

I dug into this and this is what I think is needed to support GHC 9.4

• Make doctest support GHC 9.4: Initial support for GHC 9.4 sol/doctest#382
• Release new doctest version: Bump version to 0.20.1 sol/doctest#387
• Make ed25519 support GHC 9.4: Support GHC 9.4 thoughtpolice/hs-ed25519#35
• Release new ed25519 version
• Make hstringtemplate support GHC 9.4: Just needs some version bumps, but it's hosted on hub.darcs.net, need to work out how to suggest changes there.
• Release new hstringtemplate version (Andreas: I made a revision directly on hackage: https://hackage.haskell.org/package/HStringTemplate-0.8.8/revisions/)
• Make hackage-server itself support GHC 9.4: Just needs some version bumps once the above is done, and then tests pass
• Release new hackage-server version

Does this sound right?

[andreasabel]

Thanks for digging in!
I am using doctest-parallel, not doctest, so I stroke out the first two items.
We should/must also switch to Cabal-3.8 to support the latest cabal syntax.

P.S.: With the following added to cabal.project.local and base and HTTP bump in hackage-server.cabal, cabal test succeeds:

allow-newer: ed25519:base
allow-newer: ed25519:ghc-prim
allow-newer: HStringTemplate:template-haskell

So the main work is to upgrade to Cabal-3.8.

[andreasabel]

Build attempt with Cabal-3.8.1.0 gives the following initial problems:

• Server.Framework.Instances

src/Distribution/Server/Framework/Instances.hs:122:5: error: [-Wincomplete-patterns, -Werror=incomplete-patterns]
    Pattern match(es) are non-exhaustive
    In an equation for ‘putCopy’:
        Patterns of type ‘OS’ not matched: Wasi
    |
122 |     putCopy (OtherOS s) = contain $ putWord8 0 >> safePut s
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...

src/Distribution/Server/Framework/Instances.hs:165:5: error: [-Wincomplete-patterns, -Werror=incomplete-patterns]
    Pattern match(es) are non-exhaustive
    In an equation for ‘putCopy’:
        Patterns of type ‘Arch’ not matched:
            S390X
            Wasm32
    |
165 |     putCopy (OtherArch s) = contain $ putWord8 0 >> safePut s
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...

• Distribution.Server.Util.CabalRevisions: Can be ported from hackage-cli.

src/Distribution/Server/Util/CabalRevisions.hs:343:66: error:
    • Couldn't match expected type ‘Distribution.Fields.Pretty.CommentPosition’
                  with actual type ‘[a0]’
    • In the first argument of ‘const’, namely ‘[]’
      In the first argument of ‘showFields’, namely ‘(const [])’
      In the first argument of ‘(.)’, namely ‘showFields (const [])’
    |
343 |   changesOkList changesOk "source-repository" (showFields (const []) . (:[]) . ppSourceRepo)
    |                                                                  ^^

src/Distribution/Server/Util/CabalRevisions.hs:628:17: error:
    • The constructor ‘TestSuite’ should have 4 arguments, but has been given 3
    • In the pattern: TestSuite _nameA interfaceA buildInfoA
      In an equation for ‘checkTestSuite’:
          checkTestSuite
            componentName
            (TestSuite _nameA interfaceA buildInfoA)
            (TestSuite _nameB interfaceB buildInfoB)
            = do checkSame
                   "Cannot change test-suite type" interfaceA interfaceB
                 checkBuildInfo componentName buildInfoA buildInfoB
    |
628 |                (TestSuite _nameA interfaceA buildInfoA)
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Next iteration:

• Distribution.Server.Features.BuildReports.BuildReport

src/Distribution/Server/Features/BuildReports/BuildReport.hs:314:26: error:
    • Couldn't match expected type ‘Distribution.Fields.Pretty.CommentPosition’
                  with actual type ‘[a0]’
    • In the first argument of ‘const’, namely ‘[]’
      In the first argument of ‘showFields’, namely ‘(const [])’
      In the first argument of ‘(.)’, namely ‘showFields (const [])’
    |
314 | show = showFields (const []) . prettyFieldGrammar CabalSpecV2_4 fieldDescrs
    |                          ^^

• Distribution.Server.Features.Tags.Backup

src/Distribution/Server/Features/Tags/Backup.hs:26:20: warning: [-Wincomplete-uni-patterns]
    Pattern match(es) are non-exhaustive
    In a lambda abstraction:
        Patterns of type ‘BackupEntry’ not matched: BackupBlob _ _
   |
26 |     restoreEntry = \(BackupByteString entry bs) ->
   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...

src/Distribution/Server/Features/Tags/Backup.hs:39:20: warning: [-Wincomplete-uni-patterns]
    Pattern match(es) are non-exhaustive
    In a lambda abstraction:
        Patterns of type ‘BackupEntry’ not matched: BackupBlob _ _
   |
39 |     restoreEntry = \(BackupByteString entry bs) ->
   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...

• Distribution.Server.Packages.Metadata

src/Distribution/Server/Packages/Metadata.hs:49:4: warning: [-Wincomplete-uni-patterns]
    Pattern match(es) are non-exhaustive
    In a pattern binding:
        Patterns of type ‘PkgTarball’ not matched: PkgTarball_v2_v1 _
   |
49 |    PkgTarball{..} = pkgTarball
   |    ^^^^^^^^^^^^^^^^^^^^^^^^^^^

• Distribution.Server.Features.DownloadCount

src/Distribution/Server/Features/DownloadCount.hs:195:11: warning: [-Wincomplete-uni-patterns]
    Pattern match(es) are non-exhaustive
    In a pattern binding:
        Patterns of type ‘[BackupEntry]’ not matched:
            []
            ((BackupBlob _ _):_)
            ((BackupByteString _ _):_:_)
    |
195 |       let [BackupByteString _ bs] = onDiskBackup onDiskStats
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^