Skip to content

Specify what's needed for migration away from HsColour in Haddock #2698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fuuzetsu opened this issue Jul 3, 2015 · 4 comments
Closed

Specify what's needed for migration away from HsColour in Haddock #2698

Fuuzetsu opened this issue Jul 3, 2015 · 4 comments

Comments

@Fuuzetsu
Copy link
Member

Fuuzetsu commented Jul 3, 2015

We have a GSOC student over at Haddock who has been working on Haskell source highlighter with the notable feature of hyperlinked identifiers/types/whatever, in the style of Agda files. haskell/haddock#410

If everything works fine on our end, we'll be looking to migrate away from HsColour though not straight away.

What would we have to do to make the process easy for cabal, past and present? Likewise for Hackage. For example, do you foresee any issues with us just changing what files --hyperlinked-source flag results in? Maybe there are some assumptions that cabal/hackage are making that we should be aware of. Let us know. If there's nothing then great.

@Fuuzetsu Fuuzetsu changed the title Specify what's needed for migration away from HsColour Specify what's needed for migration away from HsColour in Haddock Jul 3, 2015
@23Skidoo
Copy link
Member

23Skidoo commented Jul 3, 2015

I think we'll just need a version bump once the feature is merged in so that we can distinguish between the old and new behaviour.

@Fuuzetsu
Copy link
Member Author

Fuuzetsu commented Jul 3, 2015

Is there no need to worry at all about older versions?

@23Skidoo
Copy link
Member

23Skidoo commented Jul 4, 2015

With old versions of haddock, Cabal'll just continue using hscolour. Looking at D.S.Setup I see that we have a flag for specifying a CSS file for hscolour, so it'd be nice if Haddock continued to support hscolour-compatible CSS files. Other than that I don't see any potential problems -- do you?

If you will continue to support --source-{module,entity,entity-line}, then old versions of Cabal will continue to work with new versions of Haddock. The users won't be getting the new source hyperlinking hotness, since old Cabals will still be using hscolour with new Haddock, but that is fine.

@Fuuzetsu
Copy link
Member Author

Fuuzetsu commented Jul 4, 2015

Not really, was just double checking. Maybe @mrhania has some questions but for now I'll close.

Thanks.

@Fuuzetsu Fuuzetsu closed this as completed Jul 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants