Upgrade react-scripts on the front-end to allow for later versions of node

[trillium]

Update: Need to resolve error

Error when applcation hot rebuilds during development:

[eslint] ESLint configuration in ../.eslintrc is invalid:
    - Unexpected top-level property "babelOptions".
ERROR in [eslint] ESLint configuration in ../.eslintrc is invalid:
    - Unexpected top-level property "babelOptions".

Overview

We would like to use later versions of node, currently the frontend doesn't build unless we use node 16. The application won't build in node 17+ because of an SSL change that fixed a security vulnerability.

This issue has been around since #756

Stack Trace

Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:71:19)
    at Object.createHash (node:crypto:140:10)
    at module.exports (/Users/trilliumsmith/code/VRMS/client/node_modules/webpack/lib/util/createHash.js:135:53)
    at NormalModule._initBuildHash (/Users/trilliumsmith/code/VRMS/client/node_modules/webpack/lib/NormalModule.js:417:16)
    at handleParseError (/Users/trilliumsmith/code/VRMS/client/node_modules/webpack/lib/NormalModule.js:471:10)
    at /Users/trilliumsmith/code/VRMS/client/node_modules/webpack/lib/NormalModule.js:503:5
    at /Users/trilliumsmith/code/VRMS/client/node_modules/webpack/lib/NormalModule.js:358:12
    at /Users/trilliumsmith/code/VRMS/client/node_modules/loader-runner/lib/LoaderRunner.js:373:3
    at iterateNormalLoaders (/Users/trilliumsmith/code/VRMS/client/node_modules/loader-runner/lib/LoaderRunner.js:214:10)
    at iterateNormalLoaders (/Users/trilliumsmith/code/VRMS/client/node_modules/loader-runner/lib/LoaderRunner.js:221:10)
/Users/trilliumsmith/code/VRMS/client/node_modules/react-scripts/scripts/start.js:19
  throw err;

Upgrading react-scripts allows the the VRMS app to use later verions of node, while also closing closing a potential security vulnerabiltiy.

Action Items

• Upgrade react-scripts to latest
• Resolve warnings, errors that come from reacts-scripts upgrade #1329
• Test if the current application then runs on:
  • Node 18 (stable)
  • Node 19

Resources/Instructions

• Stack Overflow: What is --openssl-legacy-provider in Node.js v17?
• Images issue resulting from upgrading react-scripts

[MattPereira]

@spiteless I love how you wrote this issue

Just be sure to check off the action items as you complete them so that when someone reviews your PR they know which steps you have or have not completed

[trillium]

Wanting to note that Node 16 end of life is September 11th, 2023

[JackHaeg]

@spiteless I noticed that you moved this into the icebox. What is the blocker that keeps us from working on this?

[trillium]

At the time the issue was getting to a workable eslint setup. We merged a working version of the upgrade to a higher node version a couple of times but the changes were breaking the dev environment in a way that I was unable to resolve.

I’ve since worked on this some more due to the fact that node 14 is being sunset and create-react-app is also no longer the recommended way of starting react projects, but I wanted to make sure that there weren’t lingering issues.

The VRMS/vite branch fixes this ticket, but the devs need to talk as a group on whether using vite as a build tool is appropriate for VRMS.

[JackHaeg]

Thanks for the update @spiteless ! If there is time during the call tonight, could we discuss this with the devs?

[trillium]

Closing as unplanned, Vite will take care of this