Skip to content

Upgrade protobuf-java to 3.22.2 #10034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jrhee17 opened this issue Apr 11, 2023 · 6 comments
Closed

Upgrade protobuf-java to 3.22.2 #10034

jrhee17 opened this issue Apr 11, 2023 · 6 comments
Assignees
Milestone

Comments

@jrhee17
Copy link

jrhee17 commented Apr 11, 2023

Is your feature request related to a problem?

No

Describe the solution you'd like

Upgrade protobuf from 3.21.7 to 3.22.2 to keep up-to-date with the ecosystem.

Describe alternatives you've considered

n/a

Additional context

@sergiitk
Copy link
Member

sergiitk commented Apr 11, 2023

To clarify - the problem is solved from your side by updating the version of protobuf, right?

From our side - we're currently working on updating the protobuf. We don't know yet if this'd be an easy upgrade, so I can't provide you with a timeline. Ideally it'll be out as a patch-release of 1.54.

@ejona86 ejona86 self-assigned this Apr 11, 2023
@ejona86 ejona86 added this to the Next milestone Apr 11, 2023
@ejona86
Copy link
Member

ejona86 commented Apr 11, 2023

Some others recently brought up the protobuf upgrade, so I made #10041 . But as I mention on it, I think we will hold off for a little bit before merging it to let the ecosystem catch up. Java seems fine, but some of the other languages are having trouble.

@jrhee17
Copy link
Author

jrhee17 commented Apr 12, 2023

To clarify - the problem is solved from your side by updating the version of protobuf, right?

Right, but since we also use grpc-java as well as protobuf we generally try to align these dependencies.

But as I mention on it, I think we will hold off for a little bit before merging it to let the ecosystem catch up. Java seems fine, but some of the other languages are having trouble.

I see, understood and thanks 👍

@ejona86
Copy link
Member

ejona86 commented Apr 13, 2023

22.3 is out, so we'll target that instead: #10045 . That PR should actually be ready the moment it makes sense to merge.

@ejona86
Copy link
Member

ejona86 commented Apr 17, 2023

Note: users are free to upgrade the version of protobuf in their own dependency tree. The main thing is don't downgrade. Gradle won't do that, and for Maven users we strongly recommend Maven Enforcer's requireUpperBoundDeps.

@ejona86
Copy link
Member

ejona86 commented Apr 17, 2023

#10045 is merged. Let's consider this closed, even if C++ is still a TODO, you wouldn't be able to notice.

@ejona86 ejona86 closed this as completed Apr 17, 2023
@ejona86 ejona86 modified the milestones: Next, 1.55 Apr 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants