Skip to content

Add prepareMessage and sendPrepared functions #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jgupta opened this issue Nov 5, 2016 · 4 comments
Closed

Add prepareMessage and sendPrepared functions #182

jgupta opened this issue Nov 5, 2016 · 4 comments

Comments

@jgupta
Copy link

jgupta commented Nov 5, 2016

We could improve performance in pub-sub or broadcast cases if functions such as prepareMessage and sendPrepared are added (especially in case of compression)

https://github.com/uWebSockets/uWebSockets/issues/141
http://autobahn.ws/python/_modules/autobahn/websocket/interfaces.html#IWebSocketChannel.sendPreparedMessage

@garyburd
Copy link
Contributor

garyburd commented Nov 6, 2016

Describe what the feature does or link to an explanation of the feature.

@jgupta
Copy link
Author

jgupta commented Nov 7, 2016

For e.g. a message X has to be sent to N number fo clients. By default, it would do same work (Framing, compression etc) N times.

prepareMessage: Prepare message to be sent, this would do framing, compression etc.
sendPrepared: Send already prepared message by skipping framing, compression assuming all of this is already done.

http://autobahn.ws/python/reference/autobahn.websocket.html#autobahn.websocket.interfaces.IWebSocketChannel.sendPreparedMessage
http://autobahn.ws/python/reference/autobahn.websocket.html#autobahn.websocket.IWebSocketChannel.sendPreparedMessage

https://github.com/uWebSockets/uWebSockets/issues/136
https://github.com/uWebSockets/uWebSockets/issues/141

@jgupta
Copy link
Author

jgupta commented Nov 7, 2016

I understand. Is there any way we could improve performance when we are sending high throughput identical messages to over multiple clients?

@garyburd
Copy link
Contributor

Fixed by 804cb60.

@gorilla gorilla locked and limited conversation to collaborators Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants