Skip to content

x/sys/unix: TestIoctlGetEthtoolDrvinfo failures #68008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gopherbot opened this issue Jun 14, 2024 · 4 comments
Closed

x/sys/unix: TestIoctlGetEthtoolDrvinfo failures #68008

gopherbot opened this issue Jun 14, 2024 · 4 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "golang.org/x/sys/unix" && test == "TestIoctlGetEthtoolDrvinfo"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestIoctlGetEthtoolDrvinfo
    syscall_linux_test.go:61: end0: "st_gmac"
    syscall_linux_test.go:57: failed to get ethtool driver info for "end1": device or resource busy
--- FAIL: TestIoctlGetEthtoolDrvinfo (0.00s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 14, 2024
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jun 14, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jun 14, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/sys/unix" && test == "TestIoctlGetEthtoolDrvinfo"
2024-05-09 17:46 x_sys-gotip-linux-riscv64 sys@f34bb9fc go@f43d9c40 x/sys/unix.TestIoctlGetEthtoolDrvinfo (log)
=== RUN   TestIoctlGetEthtoolDrvinfo
    syscall_linux_test.go:61: end0: "st_gmac"
    syscall_linux_test.go:57: failed to get ethtool driver info for "end1": device or resource busy
--- FAIL: TestIoctlGetEthtoolDrvinfo (0.00s)
2024-05-13 22:24 x_sys-go1.21-linux-riscv64 sys@6943ab67 release-branch.go1.21@6f521957 x/sys/unix.TestIoctlGetEthtoolDrvinfo (log)
=== RUN   TestIoctlGetEthtoolDrvinfo
    syscall_linux_test.go:61: end0: "st_gmac"
    syscall_linux_test.go:57: failed to get ethtool driver info for "end1": device or resource busy
--- FAIL: TestIoctlGetEthtoolDrvinfo (0.00s)

watchflakes

@griesemer
Copy link
Contributor

ping @mdlayher

@mdlayher
Copy link
Member

It looks like #67350 and subsequent CL added a check for EBUSY which I would have expected to be the solution here. Otherwise I'm unsure where to look next.

@ianlancetaylor
Copy link
Contributor

Looks like this log was run on May 13, but the fix was committed on May 17. I don't know why watchflakes is reporting a May 13 run in June, but this is presumably fixed.

@ianlancetaylor ianlancetaylor closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Archived in project
Development

No branches or pull requests

4 participants