Skip to content

Commit 723e1ad

Browse files
committed
sweet: disable gvisor benchmark
gVisor currently does not build with Go 1.19, so exclude it from "all", "default", and integration testing until it is fixed. It can still be requested explicitly with -run=gvisor. For golang/go#51445. Change-Id: Ib839899af169ff247aa59f264c7891e16784603c Reviewed-on: https://go-review.googlesource.com/c/benchmarks/+/389754 Trust: Michael Pratt <[email protected]> Run-TryBot: Michael Pratt <[email protected]> Reviewed-by: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
1 parent 411d1f1 commit 723e1ad

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

sweet/cmd/sweet/benchmark.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,12 +108,18 @@ var benchmarkGroups = map[string][]*benchmark{
108108
allBenchmarksMap["fogleman-pt"],
109109
allBenchmarksMap["go-build"],
110110
allBenchmarksMap["gopher-lua"],
111-
allBenchmarksMap["gvisor"],
111+
// TODO(go.dev/issue/51445): Enable once gVisor builds with Go 1.19.
112+
// allBenchmarksMap["gvisor"],
112113
allBenchmarksMap["markdown"],
113114
allBenchmarksMap["tile38"],
114115
},
115116
"all": func() (b []*benchmark) {
116117
for i := range allBenchmarks {
118+
if allBenchmarks[i].name == "gvisor" {
119+
// TODO(go.dev/issue/51445): Include in "all"
120+
// once gVisor builds with Go 1.19.
121+
continue
122+
}
117123
b = append(b, &allBenchmarks[i])
118124
}
119125
return

sweet/cmd/sweet/integration_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,9 @@ func TestSweetEndToEnd(t *testing.T) {
156156
var wg sync.WaitGroup
157157
for i, shard := range []string{
158158
"tile38", "go-build", "biogo-igor", "biogo-krishna", "bleve-query",
159-
"gvisor", "fogleman-pt", "bleve-index,fogleman-fauxgl,gopher-lua,markdown",
159+
// TODO(go.dev/issue/51445): Enable once gVisor builds with Go 1.19.
160+
// "gvisor",
161+
"fogleman-pt", "bleve-index,fogleman-fauxgl,gopher-lua,markdown",
160162
} {
161163
sema.Acquire(context.Background(), 1)
162164
wg.Add(1)

0 commit comments

Comments
 (0)