Skip to content

Commit d5b8da6

Browse files
TitanNanoBromeon
andauthored
Apply suggestions from code review
Co-authored-by: Jan Haller <[email protected]>
1 parent 62565d0 commit d5b8da6

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

godot-core/src/builtin/signal.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ impl Signal {
3939
T: GodotClass,
4040
S: Into<StringName>,
4141
{
42-
let signal = signal_name.into();
42+
let signal_name = signal_name.into();
4343
unsafe {
4444
sys::from_sys_init_or_init_default::<Self>(|self_ptr| {
4545
let ctor = sys::builtin_fn!(signal_from_object_signal);
@@ -57,7 +57,7 @@ impl Signal {
5757
///
5858
/// A signal can only be connected once to the same [`Callable`]. If the signal is already connected,
5959
/// returns [`Error::ERR_INVALID_PARAMETER`] and
60-
/// pushes an error message, unless the signal is connected with [`ConnectFlags::CONNECT_REFERENCE_COUNTED`](crate::engine::object::ConnectFlags::CONNECT_REFERENCE_COUNTED).
60+
/// pushes an error message, unless the signal is connected with [`ConnectFlags::CONNECT_REFERENCE_COUNTED`](crate::engine::object::ConnectFlags::REFERENCE_COUNTED).
6161
/// To prevent this, use [`Self::is_connected`] first to check for existing connections.
6262
pub fn connect(&self, callable: Callable, flags: i64) -> Error {
6363
let error = self.as_inner().connect(callable, flags);
@@ -162,7 +162,7 @@ unsafe impl GodotFfi for Signal {
162162
sys::VariantType::Signal
163163
}
164164

165-
ffi_methods! { type sys::GDExtensionTypePtr = *mut Opaque;
165+
ffi_methods! { type sys::GDExtensionTypePtr = *mut Opaque;
166166
fn from_sys;
167167
fn sys;
168168
fn from_sys_init;

0 commit comments

Comments
 (0)