From 674897bc180a950c29f7ce50813db104c10140f0 Mon Sep 17 00:00:00 2001 From: delvh Date: Sun, 5 Nov 2023 15:38:19 +0100 Subject: [PATCH 1/3] Fix NPE when viewing specific range of PR commits This is the easiest fix. While other solutions might be possible, they will not be as trivial. --- web_src/js/components/DiffCommitSelector.vue | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/web_src/js/components/DiffCommitSelector.vue b/web_src/js/components/DiffCommitSelector.vue index 3f7100d201db4..118d1be8adc39 100644 --- a/web_src/js/components/DiffCommitSelector.vue +++ b/web_src/js/components/DiffCommitSelector.vue @@ -94,7 +94,8 @@ export default { focusElem(elem, prevElem) { if (elem) { elem.tabIndex = 0; - prevElem.tabIndex = -1; + if(prevElem) + prevElem.tabIndex = -1; elem.focus(); } }, From 586dfc06451a7f035787112728cf8c6a7a66cdb3 Mon Sep 17 00:00:00 2001 From: delvh Date: Sun, 5 Nov 2023 15:46:29 +0100 Subject: [PATCH 2/3] Fix whitespace --- web_src/js/components/DiffCommitSelector.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web_src/js/components/DiffCommitSelector.vue b/web_src/js/components/DiffCommitSelector.vue index 118d1be8adc39..aa85a2209c5f6 100644 --- a/web_src/js/components/DiffCommitSelector.vue +++ b/web_src/js/components/DiffCommitSelector.vue @@ -94,7 +94,7 @@ export default { focusElem(elem, prevElem) { if (elem) { elem.tabIndex = 0; - if(prevElem) + if (prevElem) prevElem.tabIndex = -1; elem.focus(); } From 81e0f815941c681c0ff9f088c22aba335b340c61 Mon Sep 17 00:00:00 2001 From: delvh Date: Sun, 5 Nov 2023 15:49:35 +0100 Subject: [PATCH 3/3] Use singleline fix instead --- web_src/js/components/DiffCommitSelector.vue | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/web_src/js/components/DiffCommitSelector.vue b/web_src/js/components/DiffCommitSelector.vue index aa85a2209c5f6..439840c30639f 100644 --- a/web_src/js/components/DiffCommitSelector.vue +++ b/web_src/js/components/DiffCommitSelector.vue @@ -94,8 +94,7 @@ export default { focusElem(elem, prevElem) { if (elem) { elem.tabIndex = 0; - if (prevElem) - prevElem.tabIndex = -1; + if (prevElem) prevElem.tabIndex = -1; elem.focus(); } },