From 935460f5eaef7fbde50a4c954b4904d76acb8f36 Mon Sep 17 00:00:00 2001 From: jackHay22 Date: Mon, 9 May 2022 11:57:36 -0400 Subject: [PATCH 1/2] add tooltip to pending PR comments --- options/locale/locale_en-US.ini | 1 + templates/repo/diff/comments.tmpl | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini index d43e34dd82de5..c7f1f0bd1a342 100644 --- a/options/locale/locale_en-US.ini +++ b/options/locale/locale_en-US.ini @@ -1463,6 +1463,7 @@ issues.review.add_review_request = "requested review from %s %s" issues.review.remove_review_request = "removed review request for %s %s" issues.review.remove_review_request_self = "refused to review %s" issues.review.pending = Pending +issues.review.pending.tooltip = This comment is not currently visible to other users. To submit your pending comments, select 'Review' -> 'Approve/Comment/Request changes' at the top of the page. issues.review.review = Review issues.review.reviewers = Reviewers issues.review.outdated = Outdated diff --git a/templates/repo/diff/comments.tmpl b/templates/repo/diff/comments.tmpl index 863e295862854..ac1ac9a8c1fac 100644 --- a/templates/repo/diff/comments.tmpl +++ b/templates/repo/diff/comments.tmpl @@ -37,7 +37,7 @@
{{if and .Review}} {{if eq .Review.Type 0}} -
+
{{$.root.i18n.Tr "repo.issues.review.pending"}}
{{else}} From a7d733cb9d600587dde91f06cfca36349829cdd5 Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Mon, 9 May 2022 20:37:18 +0200 Subject: [PATCH 2/2] reuse translated strings --- options/locale/locale_en-US.ini | 2 +- templates/repo/diff/comments.tmpl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini index c7f1f0bd1a342..ba619b413cbc9 100644 --- a/options/locale/locale_en-US.ini +++ b/options/locale/locale_en-US.ini @@ -1463,7 +1463,7 @@ issues.review.add_review_request = "requested review from %s %s" issues.review.remove_review_request = "removed review request for %s %s" issues.review.remove_review_request_self = "refused to review %s" issues.review.pending = Pending -issues.review.pending.tooltip = This comment is not currently visible to other users. To submit your pending comments, select 'Review' -> 'Approve/Comment/Request changes' at the top of the page. +issues.review.pending.tooltip = This comment is not currently visible to other users. To submit your pending comments, select '%s' -> '%s/%s/%s' at the top of the page. issues.review.review = Review issues.review.reviewers = Reviewers issues.review.outdated = Outdated diff --git a/templates/repo/diff/comments.tmpl b/templates/repo/diff/comments.tmpl index ac1ac9a8c1fac..6a581ba04a072 100644 --- a/templates/repo/diff/comments.tmpl +++ b/templates/repo/diff/comments.tmpl @@ -37,7 +37,7 @@
{{if and .Review}} {{if eq .Review.Type 0}} -
+
{{$.root.i18n.Tr "repo.issues.review.pending"}}
{{else}}