Mirror repositories use their last sync time instead of latest commit time for profile page repository ordering

[smkent]

• Gitea version (or commit ref): 1.3.1
• Git version: 2.13.6
• Operating system: Gentoo Linux
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL) https://try.gitea.io/testrepo1/gitea-mirror-test
  • No
  • Not relevant
• Log gist:

Description

Every time a mirror repository syncs with its upstream repository (every 8 hours by default), the Gitea mirror repository's last updated time is set to the current time even if there are no upstream changes. This continually causes mirror repositories to be listed higher than other repositories in the Gitea user profile page that contains mirror repositories.

Gitea should instead use the most recent commit time in a mirror repository when determining profile page repository ordering.

This can be reproduced with the following steps:

1. Create a mirror repository and wait for it to finish syncing.
2. Create a new source repository and push some content to it.
3. View the user profile for the two created repositories, and note that the source repository is listed first.
4. Open the mirror repository, click Settings, and under Mirror Settings click "Sync Now"
5. Return to the user profile page, and note that the mirror repository is now listed first (with a more recent updated time) even if no new changes were pulled from upstream

What should happen instead:

• Mirror repositories should determine the most recent commit timestamp in a mirror repository (for all synced branches), and use that timestamp to when determining the repository order to display on the user profile page.

[lafriks]

Duplicate of #1329