[1.17.0-RC2] Incorrect ROOT_URL warning when using proxy through apache

[gd197]

Description

Hello,
my configuration :
app.ini
ROOT_URL = https://host.my.company.corp/gitea
httpd gitea.conf

ProxyPass /gitea http://localhost:8888 nocanon
ProxyPassReverse /gitea http://localhost:8888
ProxyRequests Off
AllowEncodedSlashes NoDecode
ProxyPreserveHost On

output logs on starting gitea :
2022/07/27 10:34:14 cmd/web.go:221:listen() [I] [62e0f886-27] AppURL(ROOT_URL): https://host.my.company.corp/gitea/

please note the trailing slash at the end of the ROOT_URL in the log
ROOT_URL warning occurs when trying to access to https://host.my.company.corp/gitea
ROOT_URL warning does not occurs when trying to access to https://host.my.company.corp/gitea/
Did not find a way to force apache to rewrite url before proxying to application listener

Gitea Version

1.17.0-rc2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

RHEL 7.9

How are you running Gitea?

Using gitea build from github release tab

Database

MySQL

[zeripath]

Please read the instructions at https://docs.gitea.io/en-us/reverse-proxies/#apache-httpd

Your problem is occurring because of the ProxyPassReverse directive and ProxyPreserveHost.

[wxiaoguang]

I'd like to keep it open and propose a more flexible fix for the URL detection.

[wxiaoguang]

The fix: Some users visit "https://domain/gitea" while appUrl is "https://domain/gitea/", there should be no warning

• Fix ROOT_URL detection for URLs without trailing slash #20502

[gd197]

removing ProxyPassReverse directive and ProxyPreserveHost but the issue remains the same.
Tried in app.ini ROOT_URL with and without trailing slash in this configuration does not change the behavior as well

[wxiaoguang]

The PR #20502 will fix the false positive warning.

At the moment, you could bypass it by rewrite (using mod_rewrite) the "/gitea" to "/gitea/" 😂

[gd197]

thank you very much for your super fast reply, turning around mod_rewrite since yesterday but still not able to make it works, my guess is that apache is proxying first

[wxiaoguang]

You need something like this to bypass:

    RewriteEngine on
    RewriteRule ^/gitea$ /gitea/ [R=302,L]

[gd197]

this is what I'm trying but no luck :(
mod_rewrite is there and enabled
Anyway, your fix will solve that issue I can wait for.
Thanks again for your work and tips

[wxiaoguang]

Now the fix has been released to latest 1.17. You can get it from https://dl.gitea.io/gitea/1.17 or docker gitea:1.17-dev

ps: I have tested the Apache config, it should work (the rewirte need R=302 to do the redirection)

<VirtualHost *:8001>
    RewriteEngine on
    RewriteRule ^/gitea$ /gitea/ [R=302,L]

    DocumentRoot "/var/www/html/8001"
    <Proxy *>
         Order allow,deny
         Allow from all
    </Proxy>
    AllowEncodedSlashes NoDecode
    ProxyPass /gitea http://localhost:8002 nocanon
</VirtualHost>

<VirtualHost *:8002>
    DocumentRoot "/var/www/html/8002"
</VirtualHost>

$ curl -v 127.0.0.1:8001/gitea
> GET /gitea HTTP/1.1
> Host: 127.0.0.1:8001
>
< HTTP/1.1 302 Found
< Location: http://127.0.0.1:8001/gitea/
< Content-Length: 289
< ....
<p>The document has moved <a href="http://127.0.0.1:8001/gitea/">here</a>.</p>
<address>Apache/2.4.54 (Debian) Server at 127.0.0.1 Port 8001</address>