Skip to content

Deleted users may be better renamed to something other than 'Ghost' #20494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sogono opened this issue Jul 26, 2022 · 9 comments
Open

Deleted users may be better renamed to something other than 'Ghost' #20494

sogono opened this issue Jul 26, 2022 · 9 comments
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@sogono
Copy link

sogono commented Jul 26, 2022

Feature Description

A frequent contributor to one of our repositories unfortunately passed away and their user was eventually removed from the repository for the sake of organization, resulting in all of their issues and contributions now being attributed to Ghost. While rare, some users in this situation may find it uncomfortable. Clicking on links to the user 'Ghost' also leads to a 404. (v1.16.9)

Screenshots

No response

@sogono sogono added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Jul 26, 2022
@KN4CK3R
Copy link
Member

KN4CK3R commented Jul 28, 2022

You have deleted or deactivated that account?

@delvh
Copy link
Member

delvh commented Jul 28, 2022

Clicking on links to the user 'Ghost' also leads to a 404.

This sounds like a bug of its own. Normally, ghost users should not have any links. Where exactly do you see these links?

While rare, some users in this situation may find it uncomfortable

Well, an alternative would be to rename it to i.e. Unknown.
But I don't know if that can be easily done without breaking existing things...

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jul 28, 2022

@sogono
Copy link
Author

sogono commented Jul 30, 2022

Clicking on links to the user 'Ghost' also leads to a 404.

This sounds like a bug of its own. Normally, ghost users should not have any links. Where exactly do you see these links?

In the timeline of an issue where the user had added or removed Labels, there are items such as "Ghost added the label 'in-progress'" where clicking Ghost navigates to [repohost].com/Ghost which 404s

@delvh
Copy link
Member

delvh commented Jul 30, 2022

I've just created another issue so that the ghost-link issue won't be lost if this issue gets resolved.

@sogono
Copy link
Author

sogono commented Jul 30, 2022

You have deleted or deactivated that account?

I'm not sure what status the account is in since none of us have access to it. I believe the account was unassociated with our repo by the administrator.

@thekk1
Copy link

thekk1 commented Feb 10, 2025

There is an inconsistent handling for deleted users in different views.

While the name column at the commits view have the correct full name without a link from a deleted user, which is correct and wanted, the activity notifications inside of an issue have a now a ghost tag with a link to nowhere.

@KN4CK3R
Copy link
Member

KN4CK3R commented Feb 10, 2025

The name of the committer is stored inside Git. That's the reason why there is still a name displayed. But that name must not be the name used by the user in Gitea.

@thekk1
Copy link

thekk1 commented Feb 10, 2025

The name of the committer is stored inside Git. That's the reason why there is still a name displayed. But that name must not be the name used by the user in Gitea.

This makes sense i.e. for setting a tag or writing a comment but not for messages like "Ghost referenced this Issue 2025-02-07 +01: 00 from a commit" because this notification comes directly from and refers directly to the commit where the user name is still known.
Again, this could and should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

5 participants