Skip to content

Simplify and unify PROTOCOL/DOMAIN/etc #17922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mscherer opened this issue Dec 6, 2021 · 1 comment
Open

Simplify and unify PROTOCOL/DOMAIN/etc #17922

mscherer opened this issue Dec 6, 2021 · 1 comment

Comments

@mscherer
Copy link
Contributor

mscherer commented Dec 6, 2021

Feature Description

On #17771, @zeripath proposed to replace the current configuration (HTTP_ADDR + HTTP_PORT + maybe others) by a unified config ADDRESS.

But before coding, we need to agree on what it would look like and what would need to be achieved by the change.

Screenshots

No response

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Dec 6, 2021

Too many users do wrong to their setting values. Wrong ROOT_URL, wrong LOCAL_ROOT_URL, wrong CORS/COOKIE/DOMAIN, I agree these settings should be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants