-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Allow loading all secrets via separate URI #16603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Indeed, we'd be open for a PR for this, as it allows for secrets to be passed via docker/kubernetes secrets etc... cc: @justusbunsi |
I guess it wouldn't be much to do. Should be similar to what was done here. https://github.com/go-gitea/gitea/blob/main/modules/setting/setting.go#L1028 |
Honestly, the biggest (potential) issue is how the minio/captcha secrets should be loaded, since it would make sense in those cases to group together the credential pair into one file. But yeah, the code for the internal token should mostly cover all the cases we want. Bonus points if you can make gitea run the various generate commands for non-existent files before running if they don't exist. |
Updated issue description to be a checklist for the settings that are converted over, since #19663 implements this for |
Uh oh!
There was an error while loading. Please reload this page.
Right now, the
security.INTERNAL_TOKEN_URI
option allows loading thesecurity.INTERNAL_TOKEN
parameter via a separate file. It would be nice if we could extend this to the other secrets inapp.ini
as well.The variables I found that could use this:
oauth.JWT_SECRET
(currently,JWT_SIGNING_PRIVATE_KEY_FILE
is used for RSA and ECDSA, but a separate file cannot be used for HMAC)server.LFS_JWT_SECRET
security.SECRET_KEY
(Allow specifying SECRET_KEY_URI, similar to INTERNAL_TOKEN_URI #19663)service.{RE,H}CAPTCHA_{SECRET,SITEKEY}
storage.MINIO_{ACCESS_KEY_ID,SECRET_ACCESS_KEY}
(and similar sections likelfs
andattachment
)Note that this is related to (but not the same as) #4860.
The text was updated successfully, but these errors were encountered: