Skip to content

Commit fc62992

Browse files
authored
Skip known flaky queue tests on CI environment (#24419)
Random CI failures are annoying. It's better to just skip the affected tests so maintainers can use their valuable time for more productive topics. Related: #23608 Related: #23977 Related: #18703
1 parent 9cf721e commit fc62992

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

modules/queue/queue_channel_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
package queue
55

66
import (
7+
"os"
78
"sync"
89
"testing"
910
"time"
@@ -101,6 +102,9 @@ func TestChannelQueue_Batch(t *testing.T) {
101102
}
102103

103104
func TestChannelQueue_Pause(t *testing.T) {
105+
if os.Getenv("CI") != "" {
106+
t.Skip("Skipping because test is flaky on CI")
107+
}
104108
lock := sync.Mutex{}
105109
var queue Queue
106110
var err error

modules/queue/unique_queue_disk_channel_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
package queue
55

66
import (
7+
"os"
78
"strconv"
89
"sync"
910
"testing"
@@ -15,6 +16,10 @@ import (
1516
)
1617

1718
func TestPersistableChannelUniqueQueue(t *testing.T) {
19+
if os.Getenv("CI") != "" {
20+
t.Skip("Skipping because test is flaky on CI")
21+
}
22+
1823
tmpDir := t.TempDir()
1924
_ = log.NewLogger(1000, "console", "console", `{"level":"warn","stacktracelevel":"NONE","stderr":true}`)
2025

0 commit comments

Comments
 (0)