Skip to content

Commit cf430d6

Browse files
committed
Remove the required SubmitReviewForm.Type, empty type (triggered by quick submit) means "comment"
1 parent 1c894c0 commit cf430d6

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

services/forms/repo_form.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,7 @@ func (f *CodeCommentForm) Validate(req *http.Request, errs binding.Errors) bindi
623623
// SubmitReviewForm for submitting a finished code review
624624
type SubmitReviewForm struct {
625625
Content string
626-
Type string `binding:"Required;In(approve,comment,reject)"`
626+
Type string
627627
CommitID string
628628
Files []string
629629
}
@@ -643,6 +643,8 @@ func (f SubmitReviewForm) ReviewType() models.ReviewType {
643643
return models.ReviewTypeComment
644644
case "reject":
645645
return models.ReviewTypeReject
646+
case "":
647+
return models.ReviewTypeComment // default to comment
646648
default:
647649
return models.ReviewTypeUnknown
648650
}

0 commit comments

Comments
 (0)