Skip to content

Commit c236e64

Browse files
authored
Don't install playwright twice (#29302)
1. `playwright/test` is already installed as part of `deps-frontend` on CI which runs before, so it's better to not install it again (on a potentially different version), and just use the version from package.json and add the `deps-frontend` dependency. 2. `PLAYWRIGHT_DIR` is a undefined variable, so I removed it ```bash $ git show c8ded77 | grep PLAYWRIGHT_DIR +playwright: $(PLAYWRIGHT_DIR) ```
1 parent 2bd999a commit c236e64

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

Makefile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -602,8 +602,7 @@ test-mssql\#%: integrations.mssql.test generate-ini-mssql
602602
test-mssql-migration: migrations.mssql.test migrations.individual.mssql.test
603603

604604
.PHONY: playwright
605-
playwright: $(PLAYWRIGHT_DIR)
606-
npm install --no-save @playwright/test
605+
playwright: deps-frontend
607606
npx playwright install $(PLAYWRIGHT_FLAGS)
608607

609608
.PHONY: test-e2e%

0 commit comments

Comments
 (0)