Skip to content

Commit b523619

Browse files
committed
Fix test
1 parent 3048360 commit b523619

File tree

5 files changed

+13
-4
lines changed

5 files changed

+13
-4
lines changed

routers/api/v1/admin/user.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ func CreateUser(ctx *context.APIContext) {
119119
user_model.IsErrEmailAlreadyUsed(err) ||
120120
db.IsErrNameReserved(err) ||
121121
db.IsErrNameCharsNotAllowed(err) ||
122+
user_model.IsErrEmailCharIsNotSupported(err) ||
122123
user_model.IsErrEmailInvalid(err) ||
123124
db.IsErrNamePatternNotAllowed(err) {
124125
ctx.Error(http.StatusUnprocessableEntity, "", err)
@@ -265,7 +266,9 @@ func EditUser(ctx *context.APIContext) {
265266
}
266267

267268
if err := user_model.UpdateUser(u, emailChanged); err != nil {
268-
if user_model.IsErrEmailAlreadyUsed(err) || user_model.IsErrEmailInvalid(err) {
269+
if user_model.IsErrEmailAlreadyUsed(err) ||
270+
user_model.IsErrEmailCharIsNotSupported(err) ||
271+
user_model.IsErrEmailInvalid(err) {
269272
ctx.Error(http.StatusUnprocessableEntity, "", err)
270273
} else {
271274
ctx.Error(http.StatusInternalServerError, "UpdateUser", err)

routers/api/v1/user/email.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,8 @@ func AddEmail(ctx *context.APIContext) {
8080
if err := user_model.AddEmailAddresses(emails); err != nil {
8181
if user_model.IsErrEmailAlreadyUsed(err) {
8282
ctx.Error(http.StatusUnprocessableEntity, "", "Email address has been used: "+err.(user_model.ErrEmailAlreadyUsed).Email)
83-
} else if user_model.IsErrEmailInvalid(err) {
83+
} else if user_model.IsErrEmailCharIsNotSupported(err) ||
84+
user_model.IsErrEmailInvalid(err) {
8485
errMsg := fmt.Sprintf("Email address %s invalid", err.(user_model.ErrEmailInvalid).Email)
8586
ctx.Error(http.StatusUnprocessableEntity, "", errMsg)
8687
} else {

routers/web/admin/users.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,8 @@ func EditUserPost(ctx *context.Context) {
389389
if user_model.IsErrEmailAlreadyUsed(err) {
390390
ctx.Data["Err_Email"] = true
391391
ctx.RenderWithErr(ctx.Tr("form.email_been_used"), tplUserEdit, &form)
392-
} else if user_model.IsErrEmailInvalid(err) {
392+
} else if user_model.IsErrEmailCharIsNotSupported(err) ||
393+
user_model.IsErrEmailInvalid(err) {
393394
ctx.Data["Err_Email"] = true
394395
ctx.RenderWithErr(ctx.Tr("form.email_invalid"), tplUserEdit, &form)
395396
} else {

routers/web/auth/auth.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -573,6 +573,9 @@ func createUserInContext(ctx *context.Context, tpl base.TplName, form interface{
573573
case user_model.IsErrEmailAlreadyUsed(err):
574574
ctx.Data["Err_Email"] = true
575575
ctx.RenderWithErr(ctx.Tr("form.email_been_used"), tpl, form)
576+
case user_model.IsErrEmailCharIsNotSupported(err):
577+
ctx.Data["Err_Email"] = true
578+
ctx.RenderWithErr(ctx.Tr("form.email_invalid"), tpl, form)
576579
case user_model.IsErrEmailInvalid(err):
577580
ctx.Data["Err_Email"] = true
578581
ctx.RenderWithErr(ctx.Tr("form.email_invalid"), tpl, form)

routers/web/user/setting/account.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,8 @@ func EmailPost(ctx *context.Context) {
188188

189189
ctx.RenderWithErr(ctx.Tr("form.email_been_used"), tplSettingsAccount, &form)
190190
return
191-
} else if user_model.IsErrEmailInvalid(err) {
191+
} else if user_model.IsErrEmailCharIsNotSupported(err) ||
192+
user_model.IsErrEmailInvalid(err) {
192193
loadAccountData(ctx)
193194

194195
ctx.RenderWithErr(ctx.Tr("form.email_invalid"), tplSettingsAccount, &form)

0 commit comments

Comments
 (0)