Fix non-alphabetic sorting of repo topics (#28938)

wackbyte · web-flow · commit a240d5dfa7e2 · 2024-01-26T14:15:57.000Z
diff --git a/models/repo/topic.go b/models/repo/topic.go
@@ -366,7 +366,7 @@ func syncTopicsInRepository(sess db.Engine, repoID int64) error {
 	topicNames := make([]string, 0, 25)
 	if err := sess.Table("topic").Cols("name").
 		Join("INNER", "repo_topic", "repo_topic.topic_id = topic.id").
-		Where("repo_topic.repo_id = ?", repoID).Desc("topic.repo_count").Find(&topicNames); err != nil {
+		Where("repo_topic.repo_id = ?", repoID).Asc("topic.name").Find(&topicNames); err != nil {
 		return err
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -366,7 +366,7 @@ func syncTopicsInRepository(sess db.Engine, repoID int64) error {`
`366`	`366`	`topicNames := make([]string, 0, 25)`
`367`	`367`	`if err := sess.Table("topic").Cols("name").`
`368`	`368`	`Join("INNER", "repo_topic", "repo_topic.topic_id = topic.id").`
`369`		`- Where("repo_topic.repo_id = ?", repoID).Desc("topic.repo_count").Find(&topicNames); err != nil {`
	`369`	`+ Where("repo_topic.repo_id = ?", repoID).Asc("topic.name").Find(&topicNames); err != nil {`
`370`	`370`	`return err`
`371`	`371`	`}`
`372`	`372`