Skip to content

Commit 26da20a

Browse files
authored
load U2F js only on pages which need it (#11585)
* load U2F js only on pages which need it * Update templates/base/head.tmpl
1 parent cb08248 commit 26da20a

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

routers/user/setting/security.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ const (
2121
func Security(ctx *context.Context) {
2222
ctx.Data["Title"] = ctx.Tr("settings")
2323
ctx.Data["PageIsSettingsSecurity"] = true
24+
ctx.Data["RequireU2F"] = true
2425

2526
if ctx.Query("openid.return_to") != "" {
2627
settingsOpenIDVerify(ctx)
@@ -68,7 +69,6 @@ func loadSecurityData(ctx *context.Context) {
6869
ctx.ServerError("GetU2FRegistrationsByUID", err)
6970
return
7071
}
71-
ctx.Data["RequireU2F"] = true
7272
}
7373

7474
tokens, err := models.ListAccessTokens(models.ListAccessTokensOptions{UserID: ctx.User.ID})

templates/base/head.tmpl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
HighlightJS: {{if .RequireHighlightJS}}true{{else}}false{{end}},
3737
SimpleMDE: {{if .RequireSimpleMDE}}true{{else}}false{{end}},
3838
Tribute: {{if .RequireTribute}}true{{else}}false{{end}},
39-
U2F: {{if .RequireU2F}}true{{else}}false{{end}},
4039
NotificationSettings: {
4140
MinTimeout: {{NotificationSettings.MinTimeout}},
4241
TimeoutStep: {{NotificationSettings.TimeoutStep}},

0 commit comments

Comments
 (0)