Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 7ced79b

Browse files
Merge pull request #1813 from github/donokuda/polish-check-details
Polish checks list in pull request details
2 parents af979f2 + b0cdcf0 commit 7ced79b

File tree

3 files changed

+19
-12
lines changed

3 files changed

+19
-12
lines changed

src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,23 +31,25 @@
3131

3232
<Grid>
3333
<Grid.ColumnDefinitions>
34-
<ColumnDefinition Width="Auto"/>
35-
<ColumnDefinition Width="Auto"/>
36-
<ColumnDefinition Width="Auto"/>
34+
<ColumnDefinition Width="Auto" SharedSizeGroup="ColumnZero" />
35+
<ColumnDefinition Width="Auto" SharedSizeGroup="ColumnOne" />
36+
<ColumnDefinition Width="Auto" SharedSizeGroup="ColumnTwo" />
3737
<ColumnDefinition Width="*"/>
38-
<ColumnDefinition Width="Auto"/>
38+
<ColumnDefinition MinWidth="50" Width="Auto" SharedSizeGroup="ColumnFour" />
3939
</Grid.ColumnDefinitions>
4040

4141
<Grid.RowDefinitions>
42-
<RowDefinition Height="32"/>
42+
<RowDefinition MaxHeight="32"/>
4343
</Grid.RowDefinitions>
4444

45-
<ghfvs:OcticonImage Grid.Column="0" Icon="check" Foreground="#2cbe4e" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Success}}"/>
46-
<ghfvs:OcticonImage Grid.Column="0" Icon="x" Foreground="#cb2431" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Failure}}"/>
47-
<ghfvs:OcticonImage Grid.Column="0" Icon="clock" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
48-
<Image Grid.Column="1" Source="{Binding Avatar}"/>
49-
<Label Grid.Column="2" Content="{Binding Title}"/>
50-
<Label Grid.Column="3" HorizontalAlignment="Right" Content="{Binding Description}" ToolTip="{Binding Description}" />
45+
<ghfvs:OcticonImage Grid.Column="0" Margin="0 0 4 0" Icon="check" Foreground="#2cbe4e" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Success}}"/>
46+
<ghfvs:OcticonImage Grid.Column="0" Margin="0 0 4 0" Icon="x" Foreground="#cb2431" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Failure}}"/>
47+
<ghfvs:OcticonImage Grid.Column="0" Margin="0 0 4 0" Icon="primitive_dot" Foreground="#f1c647" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
48+
<Image Grid.Column="1" Source="{Binding Avatar}" Height="16" Width="16" />
49+
<Label Grid.Column="2" Foreground="{DynamicResource VsBrush.WindowText}" Content="{Binding Title}"/>
50+
<!--
51+
<Label Grid.Column="3" HorizontalAlignment="Right" Content="{Binding Description}" ToolTip="{Binding Description}" />
52+
-->
5153
<Label Grid.Column="4" HorizontalAlignment="Right">
5254
<Hyperlink ToolTip="{Binding DetailsUrl}" Command="{Binding OpenDetailsUrl}">Details</Hyperlink>
5355
</Label>

src/GitHub.VisualStudio/Views/GitHubPane/PullRequestDetailView.xaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,11 @@
251251
Margin="0 8 0 0"
252252
ghfvs:ScrollingVerticalStackPanel.IsFixed="true">
253253
<ItemsControl ItemsSource="{Binding Checks}" Margin="0 4 12 4">
254+
<ItemsControl.ItemsPanel>
255+
<ItemsPanelTemplate>
256+
<StackPanel Grid.IsSharedSizeScope="True" />
257+
</ItemsPanelTemplate>
258+
</ItemsControl.ItemsPanel>
254259
<ItemsControl.ItemTemplate>
255260
<DataTemplate>
256261
<local:PullRequestCheckView/>

src/GitHub.VisualStudio/Views/GitHubPane/PullRequestListItemView.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@
100100
</TextBlock>
101101
<ghfvs:OcticonImage Icon="check" Foreground="#2cbe4e" Visibility="{Binding Checks, Converter={ghfvs:EqualsToVisibilityConverter Success}}"/>
102102
<ghfvs:OcticonImage Icon="x" Foreground="#cb2431" Visibility="{Binding Checks, Converter={ghfvs:EqualsToVisibilityConverter Failure}}"/>
103-
<ghfvs:OcticonImage Icon="clock" Visibility="{Binding Checks, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
103+
<ghfvs:OcticonImage Icon="primitive_dot" Foreground="#f1c647" Visibility="{Binding Checks, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
104104
</StackPanel>
105105
</Grid>
106106
</Grid>

0 commit comments

Comments
 (0)