Skip to content

Check if prismaIntegration can be enabled by default #14973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mydea opened this issue Jan 10, 2025 · 4 comments · Fixed by #16073
Closed

Check if prismaIntegration can be enabled by default #14973

mydea opened this issue Jan 10, 2025 · 4 comments · Fixed by #16073
Assignees
@lforst
Labels
Integration: prisma Issues related to Prisma support for the Sentry Node SDK Node.js

Comments

@mydea
Copy link
Member

mydea commented Jan 10, 2025

Description

We used to not include the prismaIntergation by default, because there were issues with CJS builds and it.
We should check if this is still the case, and otherwise try to enable this by default for v9.
@mydea mydea mentioned this issue Jan 10, 2025
Closed
@AbhiPrasad AbhiPrasad added Package: node Issues related to the Sentry Node SDK Integration: prisma Issues related to Prisma support for the Sentry Node SDK labels Jan 13, 2025
@mydea Linear
Copy link
Member Author

mydea commented Apr 10, 2025

@lforst do you know if we could actually do this now on v9? Or is this still breaking cjs users, possibly?

@lforst lforst self-assigned this Apr 14, 2025
@mydea mydea removed the Task label Apr 14, 2025
@lforst lforst mentioned this issue Apr 16, 2025
Merged
@lforst
Copy link
Member

lforst commented Apr 16, 2025

I think we still depend on Prisma shipping the package in ESM. I opened an upstream PR: prisma/prisma#26918

@lforst Linear
Copy link
Member

lforst commented Apr 16, 2025

The PR was merged. This is blocked until the PR is released but then we can update the instrumentation package and merge #16073

@stephanie-anderson stephanie-anderson removed the Package: node Issues related to the Sentry Node SDK label Apr 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025

A PR closing this issue has just been released 🚀

This issue was referenced by PR #16073, which was included in the 9.16.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lforst lforst

Labels
Integration: prisma Issues related to Prisma support for the Sentry Node SDK Node.js
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(node): Add Prisma integration by default getsentry/sentry-javascript
4 participants
@mydea @stephanie-anderson @lforst @AbhiPrasad