perf: reduce if statement for NaN (micro-optimization) (#697)

* chore(perf): reduce if statement for `NaN`

Signed-off-by: francesco <[email protected]>

* isInteger return false for Infinity and NaN

Signed-off-by: francesco <[email protected]>

* fast check for NaN

Signed-off-by: francesco <[email protected]>

* disable lint

Signed-off-by: francesco <[email protected]>

* disable only for self-compare NaN

Co-authored-by: Aras Abbasi <[email protected]>
Signed-off-by: francesco <[email protected]>

* fast check for NaN

Signed-off-by: francesco <[email protected]>

---------

Signed-off-by: francesco <[email protected]>
Co-authored-by: Aras Abbasi <[email protected]>

Author: cesco69

lib/serializer.js

@@ -25,13 +25,12 @@ module.exports = class Serializer {
 
   asInteger (i) {
     if (typeof i === 'number') {
-      if (i === Infinity || i === -Infinity) {
-        throw new Error(`The value "${i}" cannot be converted to an integer.`)
-      }
       if (Number.isInteger(i)) {
         return '' + i
       }
-      if (Number.isNaN(i)) {
+      // check if number is Infinity or NaN
+      // eslint-disable-next-line no-self-compare
+      if (i === Infinity || i === -Infinity || i !== i) {
         throw new Error(`The value "${i}" cannot be converted to an integer.`)
       }
       return this.parseInteger(i)
@@ -52,7 +51,9 @@ module.exports = class Serializer {
 
   asNumber (i) {
     const num = Number(i)
-    if (Number.isNaN(num)) {
+    // check if number is NaN
+    // eslint-disable-next-line no-self-compare
+    if (num !== num) {
       throw new Error(`The value "${i}" cannot be converted to a number.`)
     } else if (!Number.isFinite(num)) {
       return 'null'