Skip to content

Specialize BINARY_ADD and INPLACE_ADD #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markshannon opened this issue Jul 27, 2021 · 2 comments
Closed

Specialize BINARY_ADD and INPLACE_ADD #73

markshannon opened this issue Jul 27, 2021 · 2 comments
Assignees

Comments

@markshannon
Copy link
Member

markshannon commented Jul 27, 2021

Add specialization "families" for PEP 659 adaptive interpreter for BINARY_ADD and INPLACE_ADD

BINARY_ADD INPLACE_ADD are worth specializing for a few reasons.

  • The current dispatch mechanism is very general, but addition is heavily biased towards a few types.
  • The ad-hoc specialization of s += ".." for strings does a lot of work that could be done at specialization time
  • With a better implementation of integers More efficient implementation of integers #42, unspecialized integer addition will be dominated by dispatch.
@markshannon markshannon changed the title Implement BINARY_ADD specialization "family" for PEP 659 adaptive interpreter Specialize BINARY_ADD and INPLACE_ADD Jul 27, 2021
@markshannon markshannon self-assigned this Aug 16, 2021
@markshannon
Copy link
Member Author

See #101 (comment) for an alternative specialization mechanism

@markshannon
Copy link
Member Author

I think we can count this as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant