request: enable triggering warnings on every render

[joeybaker]

On the client, it's nice that development warnings are only triggered on the initial render. But, when rendering from the server with renderToString it's annoying to only have the warnings triggered the first render and then ignored on subsequent page loads.

What if render methods accepted an additional options argument?

React.render(<span>hi</span>, window.app, {alwaysWarn: false})

React.renderToString(React.createElement(El, data), {alwaysWarn: true})

Crazy ideas: This might be useful for other options too? Perhaps: appendToBody (auto-appends the second arg), or ignoreDOMCalls (automatically catches/ignores errors to for window and document APIs)?

[joeybaker]

Update: the basic problem seems to be that the loggedTypeFailures object is private.

react/src/isomorphic/classic/element/ReactElementValidator.js

Line 246 in d1a2193

if (error instanceof Error && !(error.message in loggedTypeFailures)) {

If this could be exposed publicly, users could opt-in to resetting it.

[joeybaker]

@zpao would you be open to a PR that allows the disabling of loggedTypeFailures?

[jimfb]

I'm going to close this out in favor of #4302, since that has been where most of the discussion has been taking place and I like the solution we arrived at in that thread.

[joeybaker]

Thanks @jimfb!