Namespace BearSSL in core "feels" wrong - using catch-all esp8266 instead.

Author: dok-net

cores/esp8266/Updater.cpp

@@ -10,7 +10,7 @@
 #endif
 
 #if ARDUINO_SIGNING
-namespace BearSSL {
+namespace esp8266 {
   extern UpdaterHashClass& hash;
   extern UpdaterVerifyClass& sign;
 }
@@ -38,7 +38,7 @@ UpdaterClass::UpdaterClass()
 , _progress_callback(nullptr)
 {
 #if ARDUINO_SIGNING
-  installSignature(&BearSSL::hash, &BearSSL::sign);
+  installSignature(&esp8266::hash, &esp8266::sign);
 #endif
 }
 

libraries/ESP8266WiFi/src/BearSSLHelpers.cpp

@@ -904,13 +904,18 @@ make_stack_thunk(br_ssl_engine_sendrec_buf);
 
 #endif
 
+};
+
 #if ARDUINO_SIGNING
-static PublicKey signPubKey(signing_pubkey);
-static HashSHA256 __hash;
-static SigningVerifier __sign(&signPubKey);
+namespace {
+  static BearSSL::PublicKey signPubKey(signing_pubkey);
+  static BearSSL::HashSHA256 __hash;
+  static BearSSL::SigningVerifier __sign(&signPubKey);
+};
 
-UpdaterHashClass& hash = __hash;
-UpdaterVerifyClass& sign = __sign;
+namespace esp8266 {
+  UpdaterHashClass& hash = __hash;
+  UpdaterVerifyClass& sign = __sign;
+};
 #endif
 
-};