Skip to content

Commit 559cb35

Browse files
d-a-vdevyte
authored andcommitted
spi: use const for output buffers (#4552)
1 parent 95b1348 commit 559cb35

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

libraries/SPI/SPI.cpp

+7-7
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ void SPIClass::write32(uint32_t data, bool msb) {
380380
* @param data uint8_t *
381381
* @param size uint32_t
382382
*/
383-
void SPIClass::writeBytes(uint8_t * data, uint32_t size) {
383+
void SPIClass::writeBytes(const uint8_t * data, uint32_t size) {
384384
while(size) {
385385
if(size > 64) {
386386
writeBytes_(data, 64);
@@ -393,13 +393,13 @@ void SPIClass::writeBytes(uint8_t * data, uint32_t size) {
393393
}
394394
}
395395

396-
void SPIClass::writeBytes_(uint8_t * data, uint8_t size) {
396+
void SPIClass::writeBytes_(const uint8_t * data, uint8_t size) {
397397
while(SPI1CMD & SPIBUSY) {}
398398
// Set Bits to transfer
399399
setDataBits(size * 8);
400400

401401
uint32_t * fifoPtr = (uint32_t*)&SPI1W0;
402-
uint32_t * dataPtr = (uint32_t*) data;
402+
const uint32_t * dataPtr = (uint32_t*) data;
403403
uint32_t dataSize = ((size + 3) / 4);
404404

405405
while(dataSize--) {
@@ -418,14 +418,14 @@ void SPIClass::writeBytes_(uint8_t * data, uint8_t size) {
418418
* @param size uint8_t max for size is 64Byte
419419
* @param repeat uint32_t
420420
*/
421-
void SPIClass::writePattern(uint8_t * data, uint8_t size, uint32_t repeat) {
421+
void SPIClass::writePattern(const uint8_t * data, uint8_t size, uint32_t repeat) {
422422
if(size > 64) return; //max Hardware FIFO
423423

424424
while(SPI1CMD & SPIBUSY) {}
425425

426426
uint32_t buffer[16];
427427
uint8_t *bufferPtr=(uint8_t *)&buffer;
428-
uint8_t *dataPtr = data;
428+
const uint8_t *dataPtr = data;
429429
volatile uint32_t * fifoPtr = &SPI1W0;
430430
uint8_t r;
431431
uint32_t repeatRem;
@@ -497,7 +497,7 @@ void SPIClass::writePattern(uint8_t * data, uint8_t size, uint32_t repeat) {
497497
* @param in uint8_t *
498498
* @param size uint32_t
499499
*/
500-
void SPIClass::transferBytes(uint8_t * out, uint8_t * in, uint32_t size) {
500+
void SPIClass::transferBytes(const uint8_t * out, uint8_t * in, uint32_t size) {
501501
while(size) {
502502
if(size > 64) {
503503
transferBytes_(out, in, 64);
@@ -511,7 +511,7 @@ void SPIClass::transferBytes(uint8_t * out, uint8_t * in, uint32_t size) {
511511
}
512512
}
513513

514-
void SPIClass::transferBytes_(uint8_t * out, uint8_t * in, uint8_t size) {
514+
void SPIClass::transferBytes_(const uint8_t * out, uint8_t * in, uint8_t size) {
515515
while(SPI1CMD & SPIBUSY) {}
516516
// Set in/out Bits to transfer
517517

libraries/SPI/SPI.h

+5-5
Original file line numberDiff line numberDiff line change
@@ -69,15 +69,15 @@ class SPIClass {
6969
void write16(uint16_t data, bool msb);
7070
void write32(uint32_t data);
7171
void write32(uint32_t data, bool msb);
72-
void writeBytes(uint8_t * data, uint32_t size);
73-
void writePattern(uint8_t * data, uint8_t size, uint32_t repeat);
74-
void transferBytes(uint8_t * out, uint8_t * in, uint32_t size);
72+
void writeBytes(const uint8_t * data, uint32_t size);
73+
void writePattern(const uint8_t * data, uint8_t size, uint32_t repeat);
74+
void transferBytes(const uint8_t * out, uint8_t * in, uint32_t size);
7575
void endTransaction(void);
7676
private:
7777
bool useHwCs;
7878
uint8_t pinSet;
79-
void writeBytes_(uint8_t * data, uint8_t size);
80-
void transferBytes_(uint8_t * out, uint8_t * in, uint8_t size);
79+
void writeBytes_(const uint8_t * data, uint8_t size);
80+
void transferBytes_(const uint8_t * out, uint8_t * in, uint8_t size);
8181
inline void setDataBits(uint16_t bits);
8282
};
8383

0 commit comments

Comments
 (0)