Skip to content

Modal for global error handling should be moved to "ketcher-react" #2922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Inga-Vishnivetskaia opened this issue Jul 14, 2023 · 0 comments · May be fixed by #3723
Open

Modal for global error handling should be moved to "ketcher-react" #2922

Inga-Vishnivetskaia opened this issue Jul 14, 2023 · 0 comments · May be fixed by #3723
Assignees
@chgayane
Labels
technical debt
Milestone
Refined Backlog

Comments

@Inga-Vishnivetskaia
Copy link
Collaborator

Background
Global error handling was added in PR 730. With this implementation errorHandler triggers Modal on the client / demo application which is not a reliable approach (as for example, revealed in bug 2790)

Solution
For fixing bug 2790 the Info / Error modal was moved to "ketcher-react" (PR 2868). Triggering of modal for all other errors handled in PR 730 should be also moved to "ketcher-react". In this case the client does not need to import the InfoModal component and take care about this error handling.

Additional context
The text displayed in the modal for other errors has to be verified / discussed.
@Nitvex Nitvex added this to the Refined Backlog milestone Jul 14, 2023
@rrodionov91 rrodionov91 assigned chgayane and unassigned Nitvex Dec 14, 2023
chgayane added a commit that referenced this issue Dec 18, 2023
@chgayane
#2922 - error handling is moved to ketcher-react
30094a7
chgayane added a commit that referenced this issue Dec 18, 2023
@chgayane
#2922 - error handling is moved to ketcher-react
1175dca
@chgayane chgayane linked a pull request Dec 18, 2023 that will close this issue
#2922 - Modal for global error handling should be moved to "ketcher-react" #3723
Open
9 tasks
chgayane added a commit that referenced this issue Dec 25, 2023
@chgayane
#2922 - Add info modal error handling in ketcher-react
ea34a39
chgayane added a commit that referenced this issue Dec 26, 2023
@chgayane
#2922 - Decoupled logic of subscribing/unsubscribing from events usin…
30fd14f 
…g event bus into custom hook .
chgayane added a commit that referenced this issue Dec 26, 2023
@chgayane
#2922 - Ensure ketcher and its eventBus are defined before usage
2fc36bb
chgayane added a commit that referenced this issue Dec 27, 2023
@chgayane
#2922 - Disable no-empty-function rule for errorHandler prop
9b5dc3a
chgayane added a commit that referenced this issue Dec 27, 2023
@chgayane
#2922 - Add event bus emission for handling errors in Analyze and Ope…
bc38d46 
…n components
chgayane added a commit that referenced this issue Jan 4, 2024
@chgayane
#2922 - Change load parameters for parse recovery handling
f62bb1a
chgayane added a commit that referenced this issue Jan 5, 2024
@chgayane
#2922 - removing errorHandler prop from Editor
fe181fd
chgayane added a commit that referenced this issue Jan 5, 2024
@chgayane
#2922 - Refactor dispatch in onOk function to use async/await
067cfa0
chgayane added a commit that referenced this issue Jan 5, 2024
@chgayane
#2922 - Add GLOBAL_ERROR_HANDLER event emission to load and analyse f…
cfd16c8 
…unctions
chgayane added a commit that referenced this issue Jan 5, 2024
@chgayane
#2922 - Add GLOBAL_ERROR_HANDLER event emission to load and analyse f…
c94f519 
…unctions
chgayane added a commit that referenced this issue Jan 8, 2024
@chgayane
#2922 - Add global error handling to useSubscriptionOnEvents hook
79688ac
chgayane added a commit that referenced this issue Jan 15, 2024
@chgayane
#2922 - Added optional chaining to prevent errors due to undefined event
4f28ee9
@github-project-automation github-project-automation bot moved this to In review in Technical Debt Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chgayane chgayane

Labels
technical debt
Projects
Technical Debt
Status: In review
Milestone
Refined Backlog
Development

Successfully merging a pull request may close this issue.

#2922 - Modal for global error handling should be moved to "ketcher-react" epam/ketcher
4 participants
@AlexeyGirin @Nitvex @chgayane @Inga-Vishnivetskaia