From 79411fcc9d803e02d2ed9508bfacd58e057cd5ad Mon Sep 17 00:00:00 2001 From: Steve Gordon Date: Thu, 26 Jan 2023 21:03:22 +0000 Subject: [PATCH 1/2] Add release notes for 8.0.5 --- .../release-notes-8.0.5.asciidoc | 98 +++++++++++++++++++ docs/release-notes/release-notes.asciidoc | 2 + 2 files changed, 100 insertions(+) create mode 100644 docs/release-notes/release-notes-8.0.5.asciidoc diff --git a/docs/release-notes/release-notes-8.0.5.asciidoc b/docs/release-notes/release-notes-8.0.5.asciidoc new file mode 100644 index 00000000000..dfed294f981 --- /dev/null +++ b/docs/release-notes/release-notes-8.0.5.asciidoc @@ -0,0 +1,98 @@ +[[release-notes-8.0.5]] +== Release notes v8.0.5 + +[discrete] +=== Bug fixes + +- https://github.com/elastic/elasticsearch-net/pull/7171[#7171] Fix code-gen for IndexTemplate (issue:https://github.com/elastic/elasticsearch-net/issues/7161[#7161]) +- https://github.com/elastic/elasticsearch-net/pull/7181[#7181] Fix MultiGet response deserialization for non-matched IDs (issue: https://github.com/elastic/elasticsearch-net/issues/7169[#7169]) +- https://github.com/elastic/elasticsearch-net/pull/7182[#7182] Implement Write method on SourceConfigConverter (issue: https://github.com/elastic/elasticsearch-net/issues/7170[#7170]) +- https://github.com/elastic/elasticsearch-net/pull/7205[#7205] Update to Elastic.Transport to 0.4.6 which improves the version detection used by the REST API compatibility Accept header + +[discrete] +=== Breaking changes + +In the course of fixing the code-generation for index templates to avoid serialization failures, some breaking changes were introduced. + +[discrete] +==== IndexTemplate + +`IndexTemplate` forms part of the `IndexTemplateItem` included on `GetIndexTemplateResponse`. + +* The type for the `ComposedOf` property has changed from `IReadOnlyCollection` to `IReadOnlyCollection` +* The type for the `IndexPatterns` property has changed from `Elastic.Clients.Elasticsearch.Names` to `IReadOnlyCollection` + +*_Before_* + +[source,csharp] +---- +public sealed partial class IndexTemplate +{ + ... + public IReadOnlyCollection ComposedOf { get; init; } + public Elastic.Clients.Elasticsearch.Names IndexPatterns { get; init; } + ... +} +---- + +*_After_* + +[source,csharp] +---- +public sealed partial class IndexTemplate +{ + ... + public IReadOnlyCollection ComposedOf { get; init; } + public IReadOnlyCollection IndexPatterns { get; init; } + ... +} +---- + +[discrete] +==== SimulateIndexTemplateRequest + +* The type for the `ComposedOf` property has changed from `IReadOnlyCollection` to `IReadOnlyCollection` + +*_Before_* + +[source,csharp] +---- +public sealed partial class SimulateIndexTemplateRequest +{ + ... + public IReadOnlyCollection? ComposedOf { get; set; } + ... +} +---- + +*_After_* + +[source,csharp] +---- +public sealed partial class SimulateIndexTemplateRequest +{ + ... + public IReadOnlyCollection? ComposedOf { get; set; } + ... +} +---- + +[discrete] +==== SimulateIndexTemplateRequestDescriptor and SimulateIndexTemplateRequestDescriptor + +The `ComposedOf` method signature has changed to accept `ICollection?` instead of +`ICollection?`. + +*_Before_* + +[source,csharp] +---- +public SimulateIndexTemplateRequestDescriptor ComposedOf(ICollection? composedOf) +---- + +*_After_* + +[source,csharp] +---- +public SimulateIndexTemplateRequestDescriptor ComposedOf(ICollection? composedOf) +---- \ No newline at end of file diff --git a/docs/release-notes/release-notes.asciidoc b/docs/release-notes/release-notes.asciidoc index 520c4337d74..60a1ff944f9 100644 --- a/docs/release-notes/release-notes.asciidoc +++ b/docs/release-notes/release-notes.asciidoc @@ -6,6 +6,7 @@ [discrete] == Version 8.0 +* <> * <> * <> * <> @@ -13,6 +14,7 @@ * <> include::breaking-change-policy.asciidoc[] +include::release-notes-8.0.5.asciidoc[] include::release-notes-8.0.4.asciidoc[] include::release-notes-8.0.3.asciidoc[] include::release-notes-8.0.2.asciidoc[] From 46bde3629f2fecbad1eff7b5eecb4931f4a2ac90 Mon Sep 17 00:00:00 2001 From: Steve Gordon Date: Thu, 26 Jan 2023 21:22:01 +0000 Subject: [PATCH 2/2] Fixes to release notes --- docs/release-notes/release-notes-8.0.5.asciidoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/release-notes/release-notes-8.0.5.asciidoc b/docs/release-notes/release-notes-8.0.5.asciidoc index dfed294f981..15961356b15 100644 --- a/docs/release-notes/release-notes-8.0.5.asciidoc +++ b/docs/release-notes/release-notes-8.0.5.asciidoc @@ -4,7 +4,7 @@ [discrete] === Bug fixes -- https://github.com/elastic/elasticsearch-net/pull/7171[#7171] Fix code-gen for IndexTemplate (issue:https://github.com/elastic/elasticsearch-net/issues/7161[#7161]) +- https://github.com/elastic/elasticsearch-net/pull/7171[#7171] Fix code-gen for IndexTemplate (issue: https://github.com/elastic/elasticsearch-net/issues/7161[#7161]) - https://github.com/elastic/elasticsearch-net/pull/7181[#7181] Fix MultiGet response deserialization for non-matched IDs (issue: https://github.com/elastic/elasticsearch-net/issues/7169[#7169]) - https://github.com/elastic/elasticsearch-net/pull/7182[#7182] Implement Write method on SourceConfigConverter (issue: https://github.com/elastic/elasticsearch-net/issues/7170[#7170]) - https://github.com/elastic/elasticsearch-net/pull/7205[#7205] Update to Elastic.Transport to 0.4.6 which improves the version detection used by the REST API compatibility Accept header @@ -80,7 +80,7 @@ public sealed partial class SimulateIndexTemplateRequest [discrete] ==== SimulateIndexTemplateRequestDescriptor and SimulateIndexTemplateRequestDescriptor -The `ComposedOf` method signature has changed to accept `ICollection?` instead of +The `ComposedOf` method signature has changed to accept a parameter of `ICollection?` instead of `ICollection?`. *_Before_*