Skip to content

Commit 610fe43

Browse files
Merged PR 36652: [internal/release/7.0] Merge from public
Merge from public release/7.0 to internal/release/7.0 and resolve conflicts if necessary
2 parents ba2ce58 + eb7591e commit 610fe43

File tree

4 files changed

+22
-5
lines changed

4 files changed

+22
-5
lines changed

eng/Version.Details.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -181,9 +181,9 @@
181181
<Uri>https://dev.azure.com/dnceng/internal/_git/dotnet-runtime</Uri>
182182
<Sha>567edafe6106e6b769c64f6a2ed876190baa642a</Sha>
183183
</Dependency>
184-
<Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-externals" Version="7.0.0-alpha.1.22505.1">
184+
<Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-externals" Version="7.0.0-alpha.1.24059.2">
185185
<Uri>https://github.com/dotnet/source-build-externals</Uri>
186-
<Sha>c47ba6c19d50081f90008da8bc61b3ac20348f20</Sha>
186+
<Sha>4bed7bdd937666fac4c4f351b9b02adddf8d035b</Sha>
187187
<SourceBuild RepoName="source-build-externals" ManagedOnly="true" />
188188
</Dependency>
189189
<Dependency Name="System.Configuration.ConfigurationManager" Version="7.0.0">

eng/Versions.props

+1-1
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@
137137
<MicrosoftDotNetBuildTasksInstallersVersion>7.0.0-beta.23564.5</MicrosoftDotNetBuildTasksInstallersVersion>
138138
<MicrosoftDotNetBuildTasksTemplatingVersion>7.0.0-beta.23564.5</MicrosoftDotNetBuildTasksTemplatingVersion>
139139
<!-- Packages from dotnet/source-build-externals -->
140-
<MicrosoftSourceBuildIntermediatesourcebuildexternalsVersion>7.0.0-alpha.1.22505.1</MicrosoftSourceBuildIntermediatesourcebuildexternalsVersion>
140+
<MicrosoftSourceBuildIntermediatesourcebuildexternalsVersion>7.0.0-alpha.1.24059.2</MicrosoftSourceBuildIntermediatesourcebuildexternalsVersion>
141141
<!-- Packages from dotnet/xdt -->
142142
<MicrosoftWebXdtVersion>7.0.0-preview.22423.2</MicrosoftWebXdtVersion>
143143
</PropertyGroup>

src/Components/WebView/WebView/src/Microsoft.AspNetCore.Components.WebView.csproj

+2
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@
3434

3535
<ItemGroup>
3636
<None Include="buildTransitive\Microsoft.AspNetCore.Components.WebView.props" Pack="true" PackagePath="%(Identity)" />
37+
<None Include="buildMultiTargeting\Microsoft.AspNetCore.Components.WebView.props" Pack="true" PackagePath="%(Identity)" />
38+
<None Include="build\Microsoft.AspNetCore.Components.WebView.props" Pack="true" PackagePath="%(Identity)" />
3739
</ItemGroup>
3840

3941
<ItemGroup>

src/SignalR/clients/ts/FunctionalTests/scripts/karma.local.conf.js

+17-2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
const os = require('os');
2+
13
try {
24
// Karma configuration for a local run (the default)
35
const createKarmaConfig = require("./karma.base.conf");
@@ -45,8 +47,16 @@ try {
4547
// We use the launchers themselves to figure out if the browser exists. It's a bit sneaky, but it works.
4648
tryAddBrowser("ChromeHeadlessNoSandbox", ChromeHeadlessBrowser.prototype);
4749
tryAddBrowser("ChromiumHeadlessIgnoreCert", ChromiumHeadlessBrowser.prototype);
48-
if (!tryAddBrowser("FirefoxHeadless", FirefoxHeadlessBrowser.prototype)) {
49-
tryAddBrowser("FirefoxDeveloperHeadless", FirefoxDeveloperHeadlessBrowser.prototype);
50+
51+
if (os.platform() !== 'darwin') {
52+
if (!tryAddBrowser("FirefoxHeadless", FirefoxHeadlessBrowser.prototype)) {
53+
tryAddBrowser("FirefoxDeveloperHeadless", FirefoxDeveloperHeadlessBrowser.prototype);
54+
}
55+
} else {
56+
// https://bugzilla.mozilla.org/show_bug.cgi?id=1871366
57+
// https://bugzilla.mozilla.org/show_bug.cgi?id=1871447
58+
// It looks like some Entitlements issue with Firefox and macOS, additionally, it seems 'firefox-bin' is being removed which is what the karma firefox launcher uses by default
59+
tryAddBrowser("FirefoxHeadlessMac", FirefoxHeadlessBrowser.prototype);
5060
}
5161

5262
// We need to receive an argument from the caller, but globals don't seem to work, so we use an environment variable.
@@ -71,6 +81,11 @@ try {
7181

7282
// Ignore cert errors to allow our test cert to work (NEVER do this outside of testing)
7383
flags: ["--allow-insecure-localhost", "--ignore-certificate-errors"]
84+
},
85+
FirefoxHeadlessMac: {
86+
base: 'FirefoxHeadless',
87+
88+
command: '/Applications/FireFox.app/Contents/MacOS/firefox'
7489
}
7590
},
7691
});

0 commit comments

Comments
 (0)