Skip to content

Common select fails without onInputChange #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rvsia opened this issue Jul 11, 2022 · 2 comments
Closed

Common select fails without onInputChange #1287

rvsia opened this issue Jul 11, 2022 · 2 comments
Labels
bug Something isn't working common

Comments

@rvsia
Copy link
Contributor

rvsia commented Jul 11, 2022

Scope: Common select (possibly MUI)

Description

Working on cascading select I found that the select fails when noInputChange is provided - but it should not be required.

Steps to reproduce

  1. remove onInputChange: () => null, from the example
  2. select favorite category
  3. select food
  4. change the category
select.js:160 Uncaught TypeError: _onInputChange is not a function
    at onInputChange (select.js:160:14)

Screenshot 2022-07-11 at 16 04 28

@rvsia rvsia added bug Something isn't working common labels Jul 11, 2022
@rvsia rvsia changed the title Common select fails without an Common select fails without onInputChange Jul 11, 2022
@ahmedmustafamo
Copy link
Collaborator

@rvsia I don't think it's still an issue. because i've tried to reproduce the issue and didn't appear the error anymore

image

I think it's resolved, right?

@rvsia
Copy link
Contributor Author

rvsia commented Jul 3, 2023

@AhmedMustafa2201 Yep, I checked it again and it seems it was resolved. Thank you for checking this! 👍

@rvsia rvsia closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working common
Projects
None yet
Development

No branches or pull requests

2 participants