Skip to content

Commit bb51125

Browse files
committed
added better comment for why we take a different code path with StringsDtype
1 parent ea48c7a commit bb51125

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

dask_sql/physical/rel/logical/aggregate.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,8 @@ def get_supported_aggregation(self, series):
8383
if dask_cudf is not None and isinstance(series, dask_cudf.Series):
8484
return native_agg
8585

86-
## If pandas StringDtype return native aggregation
86+
## If pandas StringDtype native aggregation works
87+
## and with ObjectDtype and Nulls native aggregation can fail
8788
if isinstance(series, dd.Series) and isinstance(
8889
series.dtype, pd.StringDtype
8990
):

0 commit comments

Comments
 (0)