[tsconfig.json] Enforce that type-only imports must be used with import type.

Thanks to microsoft/TypeScript#9191 (comment) for the tip.

Author: lgarron

Makefile

@@ -2,7 +2,7 @@
 # https://github.com/lgarron/Makefile-scripts
 
 # Note: the first command becomes the default `make` target.
-NPM_COMMANDS = build build-esm build-cjs build-bundle-global build-types build-bin build-experimental-splitting-build generate-js generate-js-parsers generate-js-svg dev clean test test-jest test-node-require test-node-import format setup lint prepack parcel-build-for-twizzle-net parcel-build-for-vr-cubing-net parcel-build-for-experiments-cubing-net parcel-build-for-twizzle-diaries
+NPM_COMMANDS = build build-esm build-cjs build-bundle-global build-types build-bin build-experimental-splitting-build build-tsc generate-js generate-js-parsers generate-js-svg dev clean test test-jest test-node-require test-node-import format setup lint prepack parcel-build-for-twizzle-net parcel-build-for-vr-cubing-net parcel-build-for-experiments-cubing-net parcel-build-for-twizzle-diaries
 
 .PHONY: $(NPM_COMMANDS)
 $(NPM_COMMANDS):

package.json

@@ -53,12 +53,13 @@
     "build-types": "npx tsc src/cubing/*.ts src/cubing/**/*.ts --declaration --emitDeclarationOnly --outDir dist/types --target es2015 --module es2020 --moduleResolution node --lib esnext,dom --resolveJsonModule --allowJs --allowSyntheticDefaultImports # TODO: unify with tsconfig.json",
     "build-bin": "npx esbuild --target=es2015 --bundle --external:three --format=esm --outfile=dist/bin/puzzle-geometry-bin.js src/bin/puzzle-geometry-bin.ts",
     "build-experimental-splitting-build": "node src/make/build.js",
+    "build-tsc": "npx tsc --build ./tsconfig.json",
     "generate-js": "npm run generate-js-parsers && npm run generate-js-svg",
     "generate-js-parsers": "npx pegjs src/cubing/alg/parser/parser-pegjs.pegjs && npx pegjs src/cubing/kpuzzle/parser/parser-pegjs.pegjs",
     "generate-js-svg": "echo \"TODO: Generating JS for SVGs is not implemented yet.\"",
     "dev": "npm run clean && npx parcel serve --no-autoinstall src/demo/index.html --port 3333 --open --dist-dir /tmp/cubing-js-parcel # cleaning is a workaround for one set of Parcel bugs, /tmp dir is a workaround dir for other Parcel bugs",
     "clean": "rm -rf dist .cache .parcel-cache .rpt2_cache /tmp/cubing-js-parcel",
-    "test": "npm run test-jest && npm run lint && npm run build-experimental-splitting-build",
+    "test": "npm run test-jest && npm run lint && npm run build-experimental-splitting-build && npm run build",
     "test-jest": "npx jest --collectCoverage",
     "test-node-require": "node src/dist-test/require.cjs",
     "test-node-import": "node src/dist-test/import.mjs",

src/cubing/puzzle-geometry/PuzzleGeometry.ts

@@ -5,7 +5,7 @@
 
 import { Move, QuantumMove } from "../alg";
 import { FaceNameSwizzler } from "./FaceNameSwizzler";
-import {
+import type {
   MoveNotation,
   PGVendoredKPuzzleDefinition,
   Transformation as KTransformation,

src/cubing/twisty/3D/puzzles/TwistyTestBox.ts

@@ -1,7 +1,7 @@
-import { Twisty3DPuzzle } from "./Twisty3DPuzzle";
+import type { Twisty3DPuzzle } from "./Twisty3DPuzzle";
 import { BoxGeometry, MeshBasicMaterial, Object3D, Mesh } from "three";
-import { AlgCursor } from "../../animation/cursor/AlgCursor";
-import { PuzzlePosition } from "../../animation/indexer/CursorTypes";
+import type { AlgCursor } from "../../animation/cursor/AlgCursor";
+import type { PuzzlePosition } from "../../animation/cursor/CursorTypes";
 
 export class TwistyTestBox extends Object3D implements Twisty3DPuzzle {
   constructor(cursor: AlgCursor) {

src/cubing/twisty/animation/cursor/CursorTypes.ts

@@ -1,5 +1,5 @@
-import { Move } from "../../../alg";
-import { Transformation as KPuzzleState } from "../../../kpuzzle";
+import type { Move } from "../../../alg";
+import type { Transformation as KPuzzleState } from "../../../kpuzzle";
 
 export type MillisecondTimestamp = number;
 

src/cubing/twisty/animation/stream/timeline-move-calculation-draft.ts

@@ -1,10 +1,9 @@
-import { BlockMove } from "../../../alg";
-import { experimentalBlockQuantumMoveName } from "../../../alg/traversal";
-import { Duration, Timestamp } from "../cursor/CursorTypes";
+import { Move, QuantumMove } from "../../../alg";
+import type { Duration, Timestamp } from "../cursor/CursorTypes";
 
 interface Event {
   timeStamp: Timestamp;
-  move: BlockMove;
+  move: Move;
 }
 
 export interface TimelineEntry {
@@ -15,7 +14,7 @@ export interface TimelineEntry {
 
 type Timeline = TimelineEntry[];
 
-function isSameAxis(move1: BlockMove, move2: BlockMove): boolean {
+function isSameAxis(move1: Move, move2: Move): boolean {
   const familyRoots =
     move1.family[0].toLowerCase() + move2.family[0].toLowerCase();
   // console.log(familyRoots);
@@ -50,10 +49,7 @@ export function toAxes(
         end: event.timeStamp + diameterMs / 2,
       };
       axes.push([lastEntry]);
-      axisMoveTracker.set(
-        experimentalBlockQuantumMoveName(lastEntry.event.move),
-        lastEntry,
-      );
+      axisMoveTracker.set(lastEntry.event.move.quantum.toString(), lastEntry);
       continue;
     }
     const newEntry: TimelineEntry = {
@@ -62,21 +58,23 @@ export function toAxes(
       end: event.timeStamp + diameterMs / 2,
     };
     if (isSameAxis(lastEntry.event.move, event.move)) {
-      const quarterName = experimentalBlockQuantumMoveName(newEntry.event.move);
+      const quarterName = newEntry.event.move.quantum.toString();
       // console.log(quarterName);
       const prev = axisMoveTracker.get(quarterName);
       // console.log("prev", prev);
       if (
         prev &&
         prev.end > newEntry.start &&
         Math.sign(prev.event.move.amount) ===
-          Math.sign(newEntry.event.move.amount)
+          Math.sign(newEntry.event.move.effectiveAmount)
       ) {
-        prev.event.move = new BlockMove(
-          prev.event.move.outerLayer,
-          prev.event.move.innerLayer,
-          prev.event.move.family,
-          prev.event.move.amount + newEntry.event.move.amount,
+        prev.event.move = new Move(
+          new QuantumMove(
+            prev.event.move.family,
+            prev.event.move.innerLayer,
+            prev.event.move.outerLayer,
+          ),
+          prev.event.move.amount + newEntry.event.move.effectiveAmount,
         );
       } else {
         axes[axes.length - 1].push(newEntry);
@@ -86,10 +84,7 @@ export function toAxes(
       // console.log("--", algPartToStringForTesting(newEntry.event.move));
       axes.push([newEntry]);
       axisMoveTracker.clear();
-      axisMoveTracker.set(
-        experimentalBlockQuantumMoveName(newEntry.event.move),
-        newEntry,
-      );
+      axisMoveTracker.set(newEntry.event.move.quantum.toString(), newEntry);
       if (newEntry.start < lastEntry.end) {
         const midpoint = (newEntry.start + lastEntry.end) / 2;
         newEntry.start = midpoint;

tsconfig.json

@@ -2,14 +2,11 @@
   "compilerOptions": {
     "alwaysStrict": true,
     "declaration": true,
-    "declarationDir": "./dist",
+    "declarationDir": "./dist/tsc",
     "declarationMap": true,
     "downlevelIteration": true,
     "esModuleInterop": true,
-    "lib": [
-      "esnext",
-      "dom"
-    ],
+    "lib": ["esnext", "dom"],
     "moduleResolution": "node",
     "noImplicitAny": true,
     "noImplicitReturns": true,
@@ -19,15 +16,9 @@
     "strictNullChecks": true,
     "target": "es2020",
     "module": "esnext",
-    "resolveJsonModule": true
+    "resolveJsonModule": true,
+    "importsNotUsedAsValues": "error"
   },
-  "include": [
-    "src/**/*",
-    "*/index.d.ts",
-    "*/index.js"
-  ],
-  "exclude": [
-    "/node_modules",
-    "/dist"
-  ]
+  "include": ["src/**/*", "*/index.d.ts", "*/index.js"],
+  "exclude": ["/node_modules", "/dist", "/src/dist-static"]
 }