Throw a \RuntimeException whenever a curl request fails (sendgrid#90)

Author: colinodell

composer.json

@@ -23,6 +23,9 @@
         "phpunit/phpunit": "~4.4",
         "squizlabs/php_codesniffer": "~2.0"
     },
+    "suggest": {
+        "composer/ca-bundle": "Including this library will ensure that a valid CA bundle is available for secure connections"
+    },
     "autoload": {
         "psr-4": {
             "SendGrid\\": "lib/"

lib/Client.php

@@ -367,6 +367,15 @@ private function createCurlOptions($method, $body = null, $headers = null)
         }
         $options[CURLOPT_HTTPHEADER] = $headers;
 
+        if (class_exists('\\Composer\\CaBundle\\CaBundle') && method_exists('\\Composer\\CaBundle\\CaBundle', 'getSystemCaRootBundlePath')) {
+            $caPathOrFile = \Composer\CaBundle\CaBundle::getSystemCaRootBundlePath();
+            if (is_dir($caPathOrFile) || (is_link($caPathOrFile) && is_dir(readlink($caPathOrFile)))) {
+                $options[CURLOPT_CAPATH] = $caPathOrFile;
+            } else {
+                $options[CURLOPT_CAINFO] = $caPathOrFile;
+            }
+        }
+
         return $options;
     }
 
@@ -415,6 +424,10 @@ private function parseResponse($channel, $content)
         $headerSize = curl_getinfo($channel, CURLINFO_HEADER_SIZE);
         $statusCode = curl_getinfo($channel, CURLINFO_HTTP_CODE);
 
+        if ($statusCode === 0) {
+            throw new \RuntimeException(curl_error($channel));
+        }
+
         $responseBody = substr($content, $headerSize);
 
         $responseHeaders = substr($content, 0, $headerSize);

test/unit/ClientTest.php

@@ -195,6 +195,16 @@ public function testCreateCurlOptionsWithBodyAndHeaders()
         ], $result);
     }
 
+    /**
+     * @expectedException \RuntimeException
+     * @expectedExceptionMessageRegExp /SSL certificate problem/
+     */
+    public function testMakeRequestWithUntrustedRootCert()
+    {
+        $client = new Client('https://untrusted-root.badssl.com/');
+        $client->makeRequest('GET', 'https://untrusted-root.badssl.com/');
+    }
+
     /**
      * @param object $obj
      * @param string $name