Process (#61)

Added tiny process library for process creation
NOTE: We do not need any extra features in the process library, it should typically behave like the std::system API
All the multi-threading and parallelization is done through the Taskflow library

Author: coder137

.gitmodules

@@ -16,3 +16,6 @@
 [submodule "taskflow"]
 	path = taskflow
 	url = https://github.com/taskflow/taskflow.git
+[submodule "tiny-process-library"]
+	path = tiny-process-library
+	url = https://gitlab.com/eidheim/tiny-process-library.git

CMakeLists.txt

@@ -26,7 +26,7 @@ if (${BUILDCC_NO_DEPRECATED})
 endif()
 
 # Testing
-
+set(BUILD_TESTING OFF CACHE BOOL "Third Party modules use these options")
 if (${CMAKE_CXX_COMPILER_ID} STREQUAL "GNU" AND ${BUILDCC_TESTING})
     set(TESTING ON)
     message("Enabling unit-testing")
@@ -83,6 +83,9 @@ set(TF_BUILD_TESTS OFF CACHE BOOL "TF Tests")
 set(TF_BUILD_EXAMPLES OFF CACHE BOOL "TF Examples")
 add_subdirectory(taskflow)
 
+add_subdirectory(tiny-process-library)
+include(cmake/target/tpl.cmake)
+
 if (${TESTING})
     set(C++11 ON CACHE BOOL "CppUTests C++11 support")
     set(CPPUTEST_FLAGS OFF CACHE BOOL "CppUTests Flags off")

README.md

@@ -15,6 +15,7 @@ Build C, C++ and ASM files in C++
   - Flatbuffers
   - Taskflow
   - CLI11
+  - Tiny Process Library
   - fmt
   - spdlog
 
@@ -89,7 +90,11 @@ cmake --build build
 ## Install
 
 ```bash
-# Generators
+# Manually
+cd [build_folder]
+sudo cmake --install .
+
+# Cpack generators
 cpack --help
 
 # ZIP
@@ -203,6 +208,7 @@ _BuildCC_ is licensed under the Apache License, Version 2.0. See [LICENSE](LICEN
 
 - [Fmtlib](https://github.com/fmtlib/fmt) (Formatting) [MIT License] [Header Only]
 - [Spdlog](https://github.com/gabime/spdlog) (Logging) [MIT License] [Header Only]
+- [Tiny Process Library](https://gitlab.com/eidheim/tiny-process-library) (Process handling) [MIT License]
 - [Taskflow](https://github.com/taskflow/taskflow) (Parallel Programming) [MIT License] [Header Only]
   - See also [3rd-Party](https://github.com/taskflow/taskflow/tree/master/3rd-party) used by Taskflow
 - [Flatbuffers](https://github.com/google/flatbuffers) (Serialization) [Apache-2.0 License]

TODO.md

@@ -4,9 +4,9 @@
 - [ ] Bootstrapping
   - [x] Via CMake
   - [ ] Via buildcc
-- [ ] Subprocess
+- [x] Subprocess/Process
+  - Tiny Process Library
   - Reproc
-  - Subprocess.h
   - Ninja Subprocess 
 - [ ] Command/Subprocess class to construct a specialized query
   - Currently, `internal::command` uses `std::system` and command tokens are passed in through `std::vector` (no sanitization or security)

buildcc/lib/target/cmake/target.cmake

@@ -11,6 +11,9 @@ target_link_libraries(target PUBLIC
     flatbuffers
     Taskflow
 )
+target_link_libraries(target PRIVATE
+    tiny-process-library::tiny-process-library
+)
 
 target_sources(target PRIVATE
     src/target/target.cpp

buildcc/lib/target/src/util/command.cpp

@@ -18,13 +18,19 @@
 
 #include "logging.h"
 
+#include "process.hpp"
+
+namespace tpl = TinyProcessLib;
+
 namespace buildcc::internal {
 
 // command
 bool command(const std::vector<std::string> &command_tokens) {
   std::string command = aggregate(command_tokens);
   buildcc::env::log_debug("system", command);
-  return system(command.c_str()) == 0;
+
+  tpl::Process process(command);
+  return process.get_exit_status() == 0;
 }
 
 } // namespace buildcc::internal

cmake/target/tpl.cmake

@@ -0,0 +1,15 @@
+if (${BUILDCC_INSTALL})
+    install(TARGETS tiny-process-library
+        EXPORT tiny-process-library-config
+        ARCHIVE DESTINATION lib
+        LIBRARY DESTINATION lib
+        RUNTIME DESTINATION bin)
+
+    install(EXPORT tiny-process-library-config
+        FILE tiny-process-library-config.cmake
+        NAMESPACE tiny-process-library::
+        DESTINATION lib/cmake/tiny-process-library
+        )
+
+    install(FILES tiny-process-library/process.hpp DESTINATION include)
+endif()

doc/software_architecture/buildcc_core_dep.PNG

@@ -15,6 +15,7 @@ find_package(spdlog_package NAMES "spdlog" REQUIRED)
 find_package(flatbuffers_package NAMES "Flatbuffers" "flatbuffers" REQUIRED)
 find_package(taskflow_package NAMES "Taskflow" "taskflow" REQUIRED)
 find_package(CLI11_package NAMES "CLI11" REQUIRED)
+find_package(tiny_process_library_package NAMES "tiny-process-library" REQUIRED)
 
 find_package(env_package NAMES "env" REQUIRED)
 find_package(toolchain_package NAMES "toolchain" REQUIRED)
@@ -31,10 +32,11 @@ message("Find package: ${spdlog_package_DIR}")
 message("Find package: ${flatbuffers_package_DIR}")
 message("Find package: ${taskflow_package_DIR}")
 message("Find package: ${CLI11_package_DIR}")
+message("Find package: ${tiny_process_library_package_DIR}")
 
 message("Find package: ${env_package_DIR}")
-message("Find package: ${toolchain_specialized_package_DIR}")
 message("Find package: ${toolchain_package_DIR}")
+message("Find package: ${toolchain_specialized_package_DIR}")
 message("Find package: ${target_package_DIR}")
 message("Find package: ${target_gcc_package_DIR}")
 message("Find package: ${target_msvc_package_DIR}")