Skip to content

API Stubs #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 29, 2019
Merged

API Stubs #28

merged 4 commits into from
Mar 29, 2019

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Mar 17, 2019

Closes #26

@nhooyr nhooyr closed this Mar 17, 2019
@nhooyr nhooyr reopened this Mar 17, 2019
@nhooyr nhooyr added this to the v1.0.0 milestone Mar 17, 2019
@nhooyr
Copy link
Contributor Author

nhooyr commented Mar 17, 2019

I settled on a combination of functional options and "data" options.

See https://news.ycombinator.com/item?id=16503839

@nhooyr
Copy link
Contributor Author

nhooyr commented Mar 17, 2019

Config structs are nice but make the default case verbose and don't read very nicely compared to a varidiac of options.

@codecov
Copy link

codecov bot commented Mar 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@04b7d0d). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##             master   #28   +/-   ##
======================================
  Coverage          ?    0%           
======================================
  Files             ?     6           
  Lines             ?    87           
  Branches          ?     0           
======================================
  Hits              ?     0           
  Misses            ?    87           
  Partials          ?     0
Impacted Files Coverage Δ
ws.go 0% <0%> (ø)
statuscode.go 0% <0%> (ø)
accept.go 0% <0%> (ø)
datatype_string.go 0% <0%> (ø)
statuscode_string.go 0% <0%> (ø)
dial.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04b7d0d...e2a32fc. Read the comment docs.

@nhooyr nhooyr changed the title Documentation and API stubs API Stubs Mar 29, 2019
@nhooyr nhooyr merged commit 4ad7142 into master Mar 29, 2019
@nhooyr nhooyr deleted the stubs branch March 29, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant