Skip to content

Commit f5ea3a2

Browse files
authored
Merge pull request #61 from codeigniter4/update-comment-usage-typed-property-from-assigns
[Rector] Update comment usage for TypedPropertyFromAssignsRector
2 parents 6122097 + ac9359a commit f5ea3a2

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

rector.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,10 @@
126126
$rectorConfig->rule(NormalizeNamespaceByPSR4ComposerAutoloadRector::class);
127127
$rectorConfig
128128
->ruleWithConfiguration(TypedPropertyFromAssignsRector::class, [
129-
// Set to false if you use in libraries, or it does create breaking changes.
129+
/**
130+
* The INLINE_PUBLIC value is default to false to avoid BC break, if you use for libraries and want to preserve BC break, you don't need to configure it, as it included in LevelSetList::UP_TO_PHP_74
131+
* Set to true for projects that allow BC break
132+
*/
130133
TypedPropertyFromAssignsRector::INLINE_PUBLIC => true,
131134
]);
132135
$rectorConfig->rule(StringClassNameToClassConstantRector::class);

src/Template/rector.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,10 @@
127127
$rectorConfig->rule(NormalizeNamespaceByPSR4ComposerAutoloadRector::class);
128128
$rectorConfig
129129
->ruleWithConfiguration(TypedPropertyFromAssignsRector::class, [
130-
// Set to false if you use in libraries, or it does create breaking changes.
130+
/**
131+
* The INLINE_PUBLIC value is default to false to avoid BC break, if you use for libraries and want to preserve BC break, you don't need to configure it, as it included in LevelSetList::UP_TO_PHP_74
132+
* Set to true for projects that allow BC break
133+
*/
131134
TypedPropertyFromAssignsRector::INLINE_PUBLIC => true,
132135
]);
133136
$rectorConfig->rule(StringClassNameToClassConstantRector::class);

0 commit comments

Comments
 (0)