-
Notifications
You must be signed in to change notification settings - Fork 32
Remove dependency on Coveralls #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This would seem prudent particularly because php-coveralls recently relaxed their Symfony dependency versions and those Symfony dependencies recently updated their minimum PHP version to 5.5.9, which exceeds this repository's current requirement of 5.3: Related: I've filed an issue with php-coveralls regarding this. |
@elazar that doesn't enforce usage of 5.5, no? 2.* versions of the symfony components should work fine. |
@Ocramius They should, but are not what's being used at this point unless the project using them explicitly sets differing versions. Here's an example of what I mean. /cc @chrismou |
Adding these to this repository's {
"require": {
"symfony/console": "~2",
"symfony/yaml": "~2",
"symfony/config": "~2",
"symfony/stopwatch": "~2"
}
} |
@pbrisbin Is this still a concern? |
Going to go ahead and close this issue for now. |
We rely on classes from satooshi/php-coveralls for converting Clover XML to the proper JSON payload for our API endpoint. It would be good to just (re)write the logic we do rely on and remove that dependency.
Example Input:
The API endpoint for reporting coverage is shared across all test reporters for all languages, so this format must be maintained.
Example Output:
Values in JSON not from XML:
The text was updated successfully, but these errors were encountered: