Fix reflect comparisons due to sync.Map changes

There's a new sync.Map implementation controllable via GOEXPERIMENT
value. In the test use cases, we likely don't care about the strict
reflect equality so we can swap to an alternative comparison
implementation.

Other uses of reflect.DeepEqual(...) at runtime don't appear to operate
over sync.Map instances and so aren't affected.

See also: https://tip.golang.org/doc/go1.24#syncpkgsync
See also: golang/go#71702

Signed-off-by: Alexander Scheel <[email protected]>

Author: cipherboy

vault/auth_test.go

@@ -5,16 +5,16 @@ package vault
 
 import (
 	"context"
-	"reflect"
 	"strings"
 	"testing"
 	"time"
 
-	"github.com/openbao/openbao/helper/testhelpers/corehelpers"
-
 	"github.com/armon/go-metrics"
+	"github.com/go-test/deep"
+
 	"github.com/openbao/openbao/helper/metricsutil"
 	"github.com/openbao/openbao/helper/namespace"
+	"github.com/openbao/openbao/helper/testhelpers/corehelpers"
 	"github.com/openbao/openbao/helper/versions"
 	"github.com/openbao/openbao/sdk/v2/helper/consts"
 	"github.com/openbao/openbao/sdk/v2/helper/jsonutil"
@@ -142,8 +142,8 @@ func TestCore_DefaultAuthTable(t *testing.T) {
 	}
 
 	// Verify matching mount tables
-	if !reflect.DeepEqual(c.auth, c2.auth) {
-		t.Fatalf("mismatch: %v %v", c.auth, c2.auth)
+	if diff := deep.Equal(c.auth, c2.auth); diff != nil {
+		t.Fatalf("mismatch:\n\tc.auth: %#v\n\tc2.auth: %#v\n\tdiff: %#v", c.auth, c2.auth, diff)
 	}
 }
 
@@ -238,8 +238,8 @@ func TestCore_EnableCredential(t *testing.T) {
 		c2Auth[entry.UUID] = entry
 	}
 
-	if !reflect.DeepEqual(cAuth, c2Auth) {
-		t.Fatalf("mismatch: %#v %#v", cAuth, c2Auth)
+	if diff := deep.Equal(cAuth, c2Auth); diff != nil {
+		t.Fatalf("mismatch:\n\tcAuth: %#v\n\tc2Auth: %#v\n\tDiff: %#v", cAuth, c2Auth, diff)
 	}
 }
 
@@ -306,8 +306,8 @@ func TestCore_EnableCredential_aws_ec2(t *testing.T) {
 		c2Auth[entry.UUID] = entry
 	}
 
-	if !reflect.DeepEqual(cAuth, c2Auth) {
-		t.Fatalf("mismatch: %#v %#v", cAuth, c2Auth)
+	if diff := deep.Equal(cAuth, c2Auth); diff != nil {
+		t.Fatalf("mismatch:\n\tcAuth: %#v\n\tc2Auth: %#v\n\tdiff: %#v", cAuth, c2Auth, diff)
 	}
 }
 
@@ -400,8 +400,8 @@ func TestCore_EnableCredential_Local(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	if !reflect.DeepEqual(oldCredential, c.auth) {
-		t.Fatalf("expected\n%#v\ngot\n%#v\n", oldCredential, c.auth)
+	if diff := deep.Equal(oldCredential, c.auth); diff != nil {
+		t.Fatalf("expected\n%#v\ngot\n%#v\ndiff: %#v\n", oldCredential, c.auth, diff)
 	}
 
 	if len(c.auth.Entries) != 2 {
@@ -508,8 +508,8 @@ func TestCore_DisableCredential(t *testing.T) {
 	}
 
 	// Verify matching mount tables
-	if !reflect.DeepEqual(c.auth, c2.auth) {
-		t.Fatalf("mismatch: %v %v", c.auth, c2.auth)
+	if diff := deep.Equal(c.auth, c2.auth); diff != nil {
+		t.Fatalf("mismatch:\n\tc.auth: %v\n\tc2.auth: %v\n\tdiff: %#v", c.auth, c2.auth, diff)
 	}
 }
 

vault/mount_test.go

@@ -376,8 +376,8 @@ func TestCore_Mount_Local(t *testing.T) {
 	}
 	c.mounts.Entries = compEntries
 
-	if !reflect.DeepEqual(oldMounts, c.mounts) {
-		t.Fatalf("expected\n%#v\ngot\n%#v\n", oldMounts, c.mounts)
+	if diff := deep.Equal(oldMounts, c.mounts); diff != nil {
+		t.Fatalf("expected\n%#v\ngot\n%#v\ndiff: %#v\n", oldMounts, c.mounts, diff)
 	}
 
 	if len(c.mounts.Entries) != 2 {