Skip to content

Commit 952573f

Browse files
committed
Fix issue link does not support quotes (go-gitea#29484)
1 parent 6d9b725 commit 952573f

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

modules/references/references.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ var (
3333
// issueNumericPattern matches string that references to a numeric issue, e.g. #1287
3434
issueNumericPattern = regexp.MustCompile(`(?:\s|^|\(|\[|\')([#!][0-9]+)(?:\s|$|\)|\]|[:;,.?!]\s|[:;,.?!]$)`)
3535
// issueAlphanumericPattern matches string that references to an alphanumeric issue, e.g. ABC-1234
36-
issueAlphanumericPattern = regexp.MustCompile(`(?:\s|^|\(|\[)([A-Z]{1,10}-[1-9][0-9]*)(?:\s|$|\)|\]|:|\.(\s|$))`)
36+
issueAlphanumericPattern = regexp.MustCompile(`(?:\s|^|\(|\[|\"|\')([A-Z]{1,10}-[1-9][0-9]*)(?:\s|$|\)|\]|:|\.(\s|$)|\"|\')`)
3737
// crossReferenceIssueNumericPattern matches string that references a numeric issue in a different repository
3838
// e.g. org/repo#12345
3939
crossReferenceIssueNumericPattern = regexp.MustCompile(`(?:\s|^|\(|\[)([0-9a-zA-Z-_\.]+/[0-9a-zA-Z-_\.]+[#!][0-9]+)(?:\s|$|\)|\]|[:;,.?!]\s|[:;,.?!]$)`)

modules/references/references_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -459,6 +459,8 @@ func TestRegExp_issueAlphanumericPattern(t *testing.T) {
459459
"(ABC-123)",
460460
"[ABC-123]",
461461
"ABC-123:",
462+
"\"ABC-123\"",
463+
"'ABC-123'",
462464
}
463465
falseTestCases := []string{
464466
"RC-08",

0 commit comments

Comments
 (0)