Fix crash on 'value_of' with fields, functions, etc.

katzdm · katzdm · commit b28f8995d056 · 2024-08-08T07:51:29.000-04:00
Closes issue llvm#84.
diff --git a/clang/lib/Sema/Metafunctions.cpp b/clang/lib/Sema/Metafunctions.cpp
@@ -2245,6 +2245,9 @@ bool value_of(APValue &Result, Sema &S, EvalFn Evaluator, DiagFn Diagnoser,
     } else if (auto *TPOD = dyn_cast<TemplateParamObjectDecl>(Decl)) {
       Value = TPOD->getValue();
       QT = TPOD->getType();
+    } else {
+      return Diagnoser(Range.getBegin(), diag::metafn_cannot_query_property)
+          << 2 << DescriptionOf(RV) << Range;
     }
 
     QualType ValueTy = S.ComputeResultType(QT, Value);

Original file line number	Diff line number	Diff line change
`@@ -2245,6 +2245,9 @@ bool value_of(APValue &Result, Sema &S, EvalFn Evaluator, DiagFn Diagnoser,`
`2245`	`2245`	`} else if (auto *TPOD = dyn_cast<TemplateParamObjectDecl>(Decl)) {`
`2246`	`2246`	`Value = TPOD->getValue();`
`2247`	`2247`	`QT = TPOD->getType();`
	`2248`	`+ } else {`
	`2249`	`+ return Diagnoser(Range.getBegin(), diag::metafn_cannot_query_property)`
	`2250`	`+ << 2 << DescriptionOf(RV) << Range;`
`2248`	`2251`	`}`
`2249`	`2252`
`2250`	`2253`	`QualType ValueTy = S.ComputeResultType(QT, Value);`