Skip to content

Commit 54f7908

Browse files
author
泰友
committed
fix: scroll back golang-lint version from 1.49.0 to 1.47.3
Golang-lint 1.48+(included) uses gofmt based on go 1.9. The result of Gofmt based on go1.9 is different from Gofmt based on go1.18([different](golang/go#54789)). As a result, Golang-lint 1.48+ reports "File is not `gofmt`-ed with `-s` (gofmt)", although gofmt(1.8 based) says the code is ok. Scroll back to golang-lint 1.47.3, which uses gofmt based on go 1.8. In the future, upgrade golang-lint when go version is higher or equal to 1.9. Signed-off-by: 泰友 <[email protected]>
1 parent dcf79ef commit 54f7908

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/smoke.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
${{ runner.os }}-golang-
3737
- name: Build Contrib
3838
run: |
39-
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sudo sh -s -- -b /usr/bin v1.49.0
39+
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sudo sh -s -- -b /usr/bin v1.47.3
4040
make -e DOCKER=false nydusify-release
4141
make -e DOCKER=false contrib-test
4242
- name: Upload Nydusify
@@ -116,7 +116,7 @@ jobs:
116116
export NYDUS_NYDUSIFY_$version_export=/usr/bin/nydus-$version/nydusify
117117
done
118118
119-
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sudo sh -s -- -b /usr/bin v1.49.0
119+
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sudo sh -s -- -b /usr/bin v1.47.3
120120
sudo -E make smoke-only
121121
122122
nydus-unit-test:

smoke/tests/tool/iterator.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ func (d *DescartesItem) Str() string {
6161
// Register("name", []interface{}{"foo", "imoer", "morgan"}).
6262
// Register("age", []interface{}{"20", "30"}).
6363
// Skip(func(item *tool.DescartesItem) bool {
64-
// // skip ("morgan", "30")
64+
// // skip ("morgan", "30")
6565
// return item.GetString("name") == "morgan" && param.GetString("age") == "30"
6666
// })
6767
//

0 commit comments

Comments
 (0)