remove .build.ps1 and various cleanup

Author: bergmeister

.build.ps1

@@ -1,5 +1,8 @@
 // Place your settings in this file to overwrite default and user settings.
 {
     "editor.tabSize": 4,
-    "powershell.codeFormatting.preset": "Allman"
-}
+    "powershell.codeFormatting.preset": "Allman",
+    "[powershell]": {
+        "files.trimTrailingWhitespace": true
+    }
+}

.vscode/settings.json

@@ -3,7 +3,7 @@
 param(
 
     [Parameter(ParameterSetName='Build')]
-    [ValidateSet('PSV3 Debug','PSV3 Release','Debug','Release')]
+    [ValidateSet('PSV3 Debug','PSV3 Release', 'Debug','Release')]
     [string] $Configuration = 'Debug',
 
     [Parameter(ParameterSetName='Build')]
@@ -77,7 +77,7 @@ if ($BuildDocs)
     {
         "Cannot find required minimum version $requiredVersionOfplatyPS of platyPS. Please install it from https://www.powershellgallery.com/packages/platyPS/ using e.g. the following command: Install-Module platyPS"
     }
-    if ((Get-Module platyPS -Verbose:$verbosity) -eq $null)
+    if ($null -eq (Get-Module platyPS -Verbose:$verbosity))
     {
         Import-Module platyPS -Verbose:$verbosity
     }
@@ -90,7 +90,7 @@ if ($BuildDocs)
 
 # Appveyor errors out due to $profile being null. Hence...
 $moduleRootPath = "$HOME/Documents/WindowsPowerShell/Modules"
-if ($profile -ne $null)
+if ($null -eq $profile)
 {
     $moduleRootPath = Join-Path (Split-Path $profile) 'Modules'
 }

build.ps1

@@ -10,7 +10,7 @@
     [string]$Configuration = "Debug"
 )
 
-if ($Configuration -match "PSv3" -and $Framework -eq "netstandard2.0")
+if ($Configuration -match "PSv" -and $Framework -eq "netstandard2.0")
 {
     throw ("{0} configuration is not applicable to {1} framework" -f $Configuration,$Framework)
 }
@@ -45,12 +45,6 @@ elseif ($Configuration -match 'PSv4') {
 
 if ($build)
 {
-
-    Write-Progress "Building Engine"
-    Push-Location Engine\
-    dotnet build Engine.csproj --framework $Framework --configuration $Configuration
-    Pop-Location
-
     Write-Progress "Building for framework $Framework, configuration $Configuration"
     Push-Location Rules\
     dotnet build Rules.csproj --framework $Framework --configuration $Configuration

buildCoreClr.ps1

@@ -42,7 +42,7 @@ function Invoke-AppVeyorBuild {
         [Parameter(Mandatory)]
         [ValidateSet('FullCLR', 'NetStandard')]
         $BuildType,
-        
+
         [Parameter(Mandatory)]
         [ValidateSet('Release', 'PSv3Release', 'PSv4Release')]
         $BuildConfiguration,
@@ -51,7 +51,7 @@ function Invoke-AppVeyorBuild {
         [ValidateScript( {Test-Path $_})]
         $CheckoutPath
     )
-    
+
     $PSVersionTable
     Write-Verbose "Pester version: $((Get-Command Invoke-Pester).Version)" -Verbose
     Write-Verbose ".NET SDK version: $(dotnet --version)" -Verbose

tools/appveyor.psm1

@@ -58,9 +58,9 @@ End {
             ReleaseTag = $ReleaseTag
         }
         $buildArgs = @{
-            RepoPath = $resolvedRepoRoot 
-            BuildJsonPath = './tools/releaseBuild/build.json' 
-            Parameters = $buildParameters 
+            RepoPath = $resolvedRepoRoot
+            BuildJsonPath = './tools/releaseBuild/build.json'
+            Parameters = $buildParameters
             AdditionalFiles = $AdditionalFiles
             Name = "win7-x64"
         }