-
Notifications
You must be signed in to change notification settings - Fork 5
Missing icons in admin #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey @piotrkwiecinski, yeah I know, we probably should do better error handling in this module, if you look at the first line of generated css, you'll see some errors. Most likely, you're running into a less/css bug in the magento pagebuilder module, here's a fix to fix those: magento/magento2-page-builder#777 (fix was created 3 years ago, but only got merged 3 weeks ago, so I guess it will be included in Magento 2.4.8) |
@hostep thank you for a quick reply. I'll try to apply the patch. Yeah another lightning fast PR processing in Magento core🙂 |
Some observations after looking a bit more closer into this:
I'm thinking of changing the default less compilation flag from Does this sound like an okay solution to you @piotrkwiecinski? |
@hostep it may be a good solution for now. Ideally we would forward these errors to stderr so they're outputted in the console. In one project in testing this module some css files aren't generated at all in the CI pipeline. I'm trying to figure out what's the difference between my local dev vs pipeline itself. I'll try to poke around the code in upcoming weeks. |
Okay, as for separating |
I have some success with Symfony\Process:
I just made quick swap for the shell runner. piotrkwiecinski@1dc7574 . I'll try to do some additional tests next with with the other project and see if it helps me with debugging missing css files. |
This got fixed in version 1.7.0, thanks! Less linting errors will now be outputted to the |
@hostep have you encountered the problem with missing icons in admin dashboard while using this plugin?
I don't see any errors in system.log.
Magento version: 2.4.6-p5
Less: 3.13.1
I tested it in 2 different projects. Looks like @font-face: 'Admin Icons' isn't added.
The text was updated successfully, but these errors were encountered: