Skip to content

Commit cbf2121

Browse files
Merge remote-tracking branch 'origin/main' into gh-161
2 parents 11e76cb + 716c9d4 commit cbf2121

File tree

8 files changed

+38
-26
lines changed

8 files changed

+38
-26
lines changed

docs/src/main/asciidoc/docker-compose.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Maven coordinates, using <<index.adoc#bill-of-materials, Spring Cloud AWS BOM>>:
1313
</dependency>
1414
----
1515

16-
For more information about Spring Docker Compose support please refer to https://docs.spring.io/spring-boot/reference/features/docker-compose.html[official Spring documentation]
16+
For more information about Spring Docker Compose support please refer to https://docs.spring.io/spring-boot/reference/features/dev-services.html#features.dev-services.docker-compose[official Spring documentation]
1717

1818
=== Example docker-compose.yaml file
1919

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<groupId>org.springframework.cloud</groupId>
88
<artifactId>spring-cloud-build</artifactId>
9-
<version>4.2.0-M2</version>
9+
<version>4.2.0</version>
1010
<relativePath/><!-- lookup parent from repository -->
1111
</parent>
1212

spring-cloud-aws-autoconfigure/src/main/java/io/awspring/cloud/autoconfigure/s3/S3AutoConfiguration.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import java.util.Optional;
3535
import org.springframework.beans.factory.ObjectProvider;
3636
import org.springframework.boot.autoconfigure.AutoConfiguration;
37-
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
3837
import org.springframework.boot.autoconfigure.condition.*;
3938
import org.springframework.boot.context.properties.EnableConfigurationProperties;
4039
import org.springframework.boot.context.properties.PropertyMapper;
@@ -53,7 +52,7 @@
5352
import software.amazon.encryption.s3.S3EncryptionClient;
5453

5554
/**
56-
* {@link EnableAutoConfiguration} for {@link S3Client} and {@link S3ProtocolResolver}.
55+
* {@link AutoConfiguration} for {@link S3Client} and {@link S3ProtocolResolver}.
5756
*
5857
* @author Maciej Walkowiak
5958
* @author Matej Nedic

spring-cloud-aws-dependencies/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
<amazon.dax.version>2.0.5</amazon.dax.version>
2929
<amazon.encryption.s3.version>3.2.3</amazon.encryption.s3.version>
3030
<maven-gpg-plugin.version>1.6</maven-gpg-plugin.version>
31-
<spring-cloud-commons.version>4.2.0-M2</spring-cloud-commons.version>
31+
<spring-cloud-commons.version>4.2.0</spring-cloud-commons.version>
3232
<jakarta.mail.version>2.1.0</jakarta.mail.version>
3333
<eclipse.jakarta.mail.version>1.0.0</eclipse.jakarta.mail.version>
3434
<bytebuddy.version>1.14.9</bytebuddy.version>

spring-cloud-aws-modulith/spring-cloud-aws-modulith-events-sns/src/test/java/io/awspring/cloud/modulith/events/sns/SnsEventPublicationIntegrationTests.java

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import org.springframework.context.annotation.Bean;
2828
import org.springframework.modulith.events.ApplicationModuleListener;
2929
import org.springframework.modulith.events.Externalized;
30+
import org.springframework.test.context.DynamicPropertyRegistrar;
3031
import org.springframework.test.context.DynamicPropertyRegistry;
3132
import org.springframework.transaction.annotation.Transactional;
3233
import org.testcontainers.containers.localstack.LocalStackContainer;
@@ -55,16 +56,17 @@ class SnsEventPublicationIntegrationTests {
5556
static class TestConfiguration {
5657

5758
@Bean
58-
LocalStackContainer localStackContainer(DynamicPropertyRegistry registry) {
59-
60-
var localstack = new LocalStackContainer(DockerImageName.parse("localstack/localstack:3.8.1"));
61-
62-
registry.add("spring.cloud.aws.endpoint", localstack::getEndpoint);
63-
registry.add("spring.cloud.aws.credentials.access-key", localstack::getAccessKey);
64-
registry.add("spring.cloud.aws.credentials.secret-key", localstack::getSecretKey);
65-
registry.add("spring.cloud.aws.region.static", localstack::getRegion);
66-
67-
return localstack;
59+
DynamicPropertyRegistrar dynamicPropertyRegistrar(LocalStackContainer localstack) {
60+
return registry -> {
61+
registry.add("spring.cloud.aws.endpoint", localstack::getEndpoint);
62+
registry.add("spring.cloud.aws.credentials.access-key", localstack::getAccessKey);
63+
registry.add("spring.cloud.aws.credentials.secret-key", localstack::getSecretKey);
64+
registry.add("spring.cloud.aws.region.static", localstack::getRegion);
65+
};
66+
}
67+
@Bean
68+
LocalStackContainer localStackContainer() {
69+
return new LocalStackContainer(DockerImageName.parse("localstack/localstack:3.8.1"));
6870
}
6971

7072
@Bean

spring-cloud-aws-modulith/spring-cloud-aws-modulith-events-sqs/src/test/java/io/awspring/cloud/modulith/events/sqs/SqsEventPublicationIntegrationTests.java

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import org.springframework.context.annotation.Bean;
2828
import org.springframework.modulith.events.ApplicationModuleListener;
2929
import org.springframework.modulith.events.Externalized;
30+
import org.springframework.test.context.DynamicPropertyRegistrar;
3031
import org.springframework.test.context.DynamicPropertyRegistry;
3132
import org.springframework.transaction.annotation.Transactional;
3233
import org.testcontainers.containers.localstack.LocalStackContainer;
@@ -53,16 +54,17 @@ class SqsEventPublicationIntegrationTests {
5354
static class TestConfiguration {
5455

5556
@Bean
56-
LocalStackContainer localStackContainer(DynamicPropertyRegistry registry) {
57-
58-
var localstack = new LocalStackContainer(DockerImageName.parse("localstack/localstack:3.8.1"));
59-
60-
registry.add("spring.cloud.aws.endpoint", localstack::getEndpoint);
61-
registry.add("spring.cloud.aws.credentials.access-key", localstack::getAccessKey);
62-
registry.add("spring.cloud.aws.credentials.secret-key", localstack::getSecretKey);
63-
registry.add("spring.cloud.aws.region.static", localstack::getRegion);
64-
65-
return localstack;
57+
DynamicPropertyRegistrar dynamicPropertyRegistrar(LocalStackContainer localstack) {
58+
return registry -> {
59+
registry.add("spring.cloud.aws.endpoint", localstack::getEndpoint);
60+
registry.add("spring.cloud.aws.credentials.access-key", localstack::getAccessKey);
61+
registry.add("spring.cloud.aws.credentials.secret-key", localstack::getSecretKey);
62+
registry.add("spring.cloud.aws.region.static", localstack::getRegion);
63+
};
64+
}
65+
@Bean
66+
LocalStackContainer localStackContainer() {
67+
return new LocalStackContainer(DockerImageName.parse("localstack/localstack:3.8.1"));
6668
}
6769

6870
@Bean

spring-cloud-aws-s3/src/main/java/io/awspring/cloud/s3/S3ProtocolResolver.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import org.springframework.core.io.Resource;
2828
import org.springframework.core.io.ResourceLoader;
2929
import org.springframework.lang.Nullable;
30+
import org.springframework.util.Assert;
3031
import software.amazon.awssdk.services.s3.S3Client;
3132

3233
/**
@@ -54,6 +55,14 @@ public class S3ProtocolResolver implements ProtocolResolver, ResourceLoaderAware
5455
public S3ProtocolResolver() {
5556
}
5657

58+
// for direct usages outside of Spring context, when BeanFactory is not available
59+
public S3ProtocolResolver(S3Client s3Client, S3OutputStreamProvider s3OutputStreamProvider) {
60+
Assert.notNull(s3Client, "s3Client is required");
61+
Assert.notNull(s3OutputStreamProvider, "s3OutputStreamProvider is required");
62+
this.s3Client = s3Client;
63+
this.s3OutputStreamProvider = s3OutputStreamProvider;
64+
}
65+
5766
// only for testing
5867
S3ProtocolResolver(@Nullable S3Client s3Client) {
5968
this.s3Client = s3Client;

spring-cloud-aws-s3/src/test/java/io/awspring/cloud/s3/S3ProtocolResolverTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
import software.amazon.awssdk.services.s3.S3Client;
3737

3838
/**
39-
* Tests for {@link S3ProtocolResolverTests}.
39+
* Tests for {@link S3ProtocolResolver}.
4040
*
4141
* @author Maciej Walkowiak
4242
*/

0 commit comments

Comments
 (0)