-
-
Notifications
You must be signed in to change notification settings - Fork 96
Backwards-incompatible change in 10.0.9 types #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
what's the best course of action for typescript users? i can revert, but I'm not going to produce a fix. |
i've reverted 10.0.9 to produce 10.0.10 (equal to 10.0.8). |
cc @tschlechtweg |
I overlooked that case. @nwalters512 please go ahead and create a PR with the changes you proposed, please also don't forget to then change the overloads of the |
I've reverted 10.0.9 as 10.0.10/11 (ugh) so please correct and open a new PR. |
#172 appears to disallow passing an
options
object without also specifying anoutput
property. This can be reproduced with the following code:TypeScript playground link: https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAbzgM2AGwKYGdgC8NwC+KUEIcA5KpjvhQNwCwAUCwMYQB2W8tBAvCnTY8GABQBGAEwBmACwBWADSI4AIwCGWDAC44UogEp6QA
If this was intentional, this should be released in a v11, as it was a breaking change. However, based on the docs, I can assume this was unintentional, as
output
is specified as having a default ofstring
, and it isn't explicitly passed in the example at the top of theREADME
. If this was indeed unintentional, I can open a PR making the following change to the types:The text was updated successfully, but these errors were encountered: